Bug 81220 - [EFL] Implement LayoutTestController::setMinimumTimerInterval
Summary: [EFL] Implement LayoutTestController::setMinimumTimerInterval
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 07:49 PDT by Sudarsana Nagineni (babu)
Modified: 2012-05-15 00:20 PDT (History)
6 users (show)

See Also:

Attachments
Implement setMinimumTimerInterval and enable related tests. (2.83 KB, patch)
2012-03-15 08:13 PDT, Sudarsana Nagineni (babu) 		pnormand: review-
pnormand: commit-queue-
Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2012-03-30 01:49 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-03-15 07:49:04 PDT 
Implement LayoutTestController::setMinimumTimerInterval for EFL port so that we can unskip related tests from the skip list.
Comment 1 Sudarsana Nagineni (babu) 2012-03-15 08:13:55 PDT 
Created attachment 132051 [details]
Implement setMinimumTimerInterval and enable related tests.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-15 08:23:53 PDT 
Comment on attachment 132051 [details]
Implement setMinimumTimerInterval and enable related tests.

Looks good, thanks.
Comment 3 Gyuyoung Kim 2012-03-15 23:47:38 PDT 
Comment on attachment 132051 [details]
Implement setMinimumTimerInterval and enable related tests.

LGTM too.
Comment 4 Philippe Normand 2012-03-30 01:24:14 PDT 
Comment on attachment 132051 [details]
Implement setMinimumTimerInterval and enable related tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review

> Tools/ChangeLog:12
> +        (LayoutTestController::setMinimumTimerInterval): Implemented.

"Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation.
Comment 5 Sudarsana Nagineni (babu) 2012-03-30 01:48:13 PDT 
(In reply to comment #4)
> (From update of attachment 132051 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review
> 
> > Tools/ChangeLog:12
> > +        (LayoutTestController::setMinimumTimerInterval): Implemented.
> 
> "Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation.

Description is already there in the changelog, so I will remove it.

Thanks for your review!
Comment 6 Sudarsana Nagineni (babu) 2012-03-30 01:49:59 PDT 
Created attachment 134745 [details]
Patch

Fix changelog entry.
Comment 7 WebKit Review Bot 2012-03-30 02:46:22 PDT 
Comment on attachment 134745 [details]
Patch

Clearing flags on attachment: 134745

Committed r112647: <http://trac.webkit.org/changeset/112647>
Comment 8 WebKit Review Bot 2012-03-30 02:46:28 PDT 
All reviewed patches have been landed.  Closing bug.