Bug 81207 - MediaStream API (JSEP): Introducing MediaHints and IceOptions
: MediaStream API (JSEP): Introducing MediaHints and IceOptions
Status: RESOLVED FIXED
: WebKit
WebKit API
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 80589
  Show dependency treegraph
 
Reported: 2012-03-15 04:24 PST by
Modified: 2012-03-15 20:45 PST (History)


Attachments
Patch (12.75 KB, patch)
2012-03-15 05:03 PST, Tommy Widenflycht
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-15 04:24:54 PST
Introducing the platform MediaHints and IceOptions helper classes.
------- Comment #1 From 2012-03-15 05:03:08 PST -------
Created an attachment (id=132021) [details]
Patch
------- Comment #2 From 2012-03-15 10:59:37 PST -------
(From update of attachment 132021 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=132021&action=review

> Source/WebCore/platform/mediastream/IceOptions.h:55
> +    IceOptions(UseCandidatesOption useCandidates) : m_useCandidates(useCandidates) { }

One-argument constructors should have the "explicit" keyword.
------- Comment #3 From 2012-03-15 11:00:18 PST -------
(From update of attachment 132021 [details])
Please consider addressing these nits in a follow-up patch.
------- Comment #4 From 2012-03-15 20:45:46 PST -------
(From update of attachment 132021 [details])
Clearing flags on attachment: 132021

Committed r110937: <http://trac.webkit.org/changeset/110937>
------- Comment #5 From 2012-03-15 20:45:50 PST -------
All reviewed patches have been landed.  Closing bug.