Bug 81206 - MediaStream API (JSEP): Introducing SessionDescription
Summary: MediaStream API (JSEP): Introducing SessionDescription
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-03-15 04:22 PDT by Tommy Widenflycht
Modified: 2012-03-15 21:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.14 KB, patch)
2012-03-15 04:57 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (22.68 KB, patch)
2012-03-15 06:17 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-03-15 04:22:39 PDT
Adding the SessionDescription JS object and its platform counterpart SessionDescriptionDescriptor.
Comment 1 Tommy Widenflycht 2012-03-15 04:57:11 PDT
Created attachment 132020 [details]
Patch
Comment 2 Tommy Widenflycht 2012-03-15 06:17:23 PDT
Created attachment 132030 [details]
Patch
Comment 3 Adam Barth 2012-03-15 10:58:27 PDT
Comment on attachment 132030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132030&action=review

> Source/WebCore/Modules/mediastream/SessionDescription.idl:41
> +        // adds the specified candidate to the description
> +        void addCandidate(in IceCandidate candidate);
> +
> +        // serializes the description to SDP
> +        DOMString toSdp();

Please remove these comments.  Folks should read the spec if they want to know what these functions do.

> Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h:57
> +    SessionDescriptionDescriptor(const String& sdp);

One-argument constructors should have the "explicit" keyword.
Comment 4 Adam Barth 2012-03-15 11:00:09 PDT
Comment on attachment 132030 [details]
Patch

Please consider addressing these nits in a follow-up patch.
Comment 5 WebKit Review Bot 2012-03-15 21:19:21 PDT
Comment on attachment 132030 [details]
Patch

Clearing flags on attachment: 132030

Committed r110943: <http://trac.webkit.org/changeset/110943>
Comment 6 WebKit Review Bot 2012-03-15 21:19:25 PDT
All reviewed patches have been landed.  Closing bug.