RESOLVED FIXED 81206
MediaStream API (JSEP): Introducing SessionDescription 
https://bugs.webkit.org/show_bug.cgi?id=81206
Summary MediaStream API (JSEP): Introducing SessionDescription
Tommy Widenflycht
Reported 2012-03-15 04:22:39 PDT
Adding the SessionDescription JS object and its platform counterpart SessionDescriptionDescriptor.
Attachments
Patch (22.14 KB, patch)
2012-03-15 04:57 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (22.68 KB, patch)
2012-03-15 06:17 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-03-15 04:57:11 PDT
Created attachment 132020 [details] Patch
Tommy Widenflycht
Comment 2 2012-03-15 06:17:23 PDT
Created attachment 132030 [details] Patch
Adam Barth
Comment 3 2012-03-15 10:58:27 PDT
Comment on attachment 132030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132030&action=review > Source/WebCore/Modules/mediastream/SessionDescription.idl:41 > + // adds the specified candidate to the description > + void addCandidate(in IceCandidate candidate); > + > + // serializes the description to SDP > + DOMString toSdp(); Please remove these comments. Folks should read the spec if they want to know what these functions do. > Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h:57 > + SessionDescriptionDescriptor(const String& sdp); One-argument constructors should have the "explicit" keyword.
Adam Barth
Comment 4 2012-03-15 11:00:09 PDT
Comment on attachment 132030 [details] Patch Please consider addressing these nits in a follow-up patch.
WebKit Review Bot
Comment 5 2012-03-15 21:19:21 PDT
Comment on attachment 132030 [details] Patch Clearing flags on attachment: 132030 Committed r110943: <http://trac.webkit.org/changeset/110943>
WebKit Review Bot
Comment 6 2012-03-15 21:19:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.