Bug 81197 – [BlackBerry] Can not open certain links from bridge applications

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Robin Cao]

Can not open certain links (e.g., target="_blank") from bridge applications. Patch coming up to fix this problem.

[Robin Cao]

Created attachment 132009 [details]
patch

[Rob Buis]

Comment on attachment 132009 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132009&action=review

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1068
> +    // how to handle patterns such as 'mailto:'.

Where are we giving that chance iafter this patch? I thought the disabled block did that.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1075
> +    // }

I think putting this in a #if 0 block would make this look less messy.

[Robin Cao]

(In reply to comment #2)
> (From update of attachment 132009 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132009&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1068
> > +    // how to handle patterns such as 'mailto:'.
> 
> Where are we giving that chance iafter this patch? I thought the disabled block did that.
> 

The following is the updated comments, hope this explains things better.

    // FIXME: Enable these commented out when WebPageClient::handleStringPattern is implemented
    // and exposed to client. Before that, don't return PolicyIgnore so we can continue to
    // create new window and get to dispatchDecidePolicyForNavigationAction() where the client
    // is given a chance to decide how to handle patterns such as 'mailto:'.

> > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1075
> > +    // }
> 
> I think putting this in a #if 0 block would make this look less messy.
Will use "#if 0" in the updated patch.

[Robin Cao]

Created attachment 132216 [details]
updated patch

[Build Bot]

Comment on attachment 132216 [details]
updated patch

Attachment 132216 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11966017

[Charles Wei]

Comment on attachment 132216 [details]
updated patch

LGTM.

We need to implement "handleExternalLoad" and "handleStringPattern" sometime.

[WebKit Review Bot]

Comment on attachment 132216 [details]
updated patch

Rejecting attachment 132216 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Charles Wei]

Comment on attachment 132216 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132216&action=review

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1077
> +#endif

Yes,  we didn't implement handleStringPattern yet, so we should never reach here until that's been implemented.

[Rob Buis]

Comment on attachment 132216 [details]
updated patch

LGTM.

[WebKit Review Bot]

Comment on attachment 132216 [details]
updated patch

Clearing flags on attachment: 132216

Committed r111000: <http://trac.webkit.org/changeset/111000>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.