Bug 81194 - Can't swipe to go back/forward when the current page is a PDF document
Summary: Can't swipe to go back/forward when the current page is a PDF document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-03-14 23:26 PDT by Anders Carlsson
Modified: 2012-03-15 14:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.50 KB, patch)
2012-03-14 23:29 PDT, Anders Carlsson
sam: review+
kdecker: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-14 23:26:28 PDT
Can't swipe to go back/forward when the current page is a PDF document
Comment 1 Anders Carlsson 2012-03-14 23:29:47 PDT
Created attachment 131993 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-03-14 23:50:02 PDT
Isn't this part of <rdar://problem/4347183>?
Comment 3 Alexey Proskuryakov 2012-03-14 23:51:53 PDT
OK, I see the relationship between that and <rdar://problem/6954125> now. Was confused because this bug didn't have InRadar keyword.
Comment 4 mitz 2012-03-14 23:52:32 PDT
Comment on attachment 131993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review

> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499
> +    if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward()))

Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping.
Comment 5 Build Bot 2012-03-15 01:37:53 PDT
Comment on attachment 131993 [details]
Patch

Attachment 131993 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11954541
Comment 6 Anders Carlsson 2012-03-15 11:51:01 PDT
(In reply to comment #4)
> (From update of attachment 131993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499
> > +    if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward()))
> 
> Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping.

We check the same thing in the web process in two places, I don't really see a good way to share the code between them.
Comment 7 Sam Weinig 2012-03-15 14:07:06 PDT
Comment on attachment 131993 [details]
Patch

Please fix the build before landing.
Comment 8 Anders Carlsson 2012-03-15 14:16:29 PDT
Committed r110885: <http://trac.webkit.org/changeset/110885>