Can't swipe to go back/forward when the current page is a PDF document
Created attachment 131993 [details] Patch
Isn't this part of <rdar://problem/4347183>?
OK, I see the relationship between that and <rdar://problem/6954125> now. Was confused because this bug didn't have InRadar keyword.
Comment on attachment 131993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499 > + if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward())) Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping.
Comment on attachment 131993 [details] Patch Attachment 131993 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11954541
(In reply to comment #4) > (From update of attachment 131993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review > > > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499 > > + if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward())) > > Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping. We check the same thing in the web process in two places, I don't really see a good way to share the code between them.
Comment on attachment 131993 [details] Patch Please fix the build before landing.
Committed r110885: <http://trac.webkit.org/changeset/110885>