RESOLVED FIXED 81179
Add asserts and improve logging in PageCache. 
https://bugs.webkit.org/show_bug.cgi?id=81179
Summary Add asserts and improve logging in PageCache.
Gavin Peters
Reported 2012-03-14 18:25:40 PDT
Add asserts and improve logging in PageCache.
Attachments
Patch (9.22 KB, patch)
2012-03-14 18:35 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-03-14 18:35:58 PDT
Created attachment 131971 [details] Patch
Gavin Peters
Comment 2 2012-03-14 18:39:01 PDT
The early exits from logCanCacheFrameDecision had the potential to skew histogram data. Moving the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps the logged data mostly accurate. I'm grumpy about making the logging more verbose in some situations, but with the DocumentLoader check moved up top, I couldn't trigger a difference in Chromium. An alternative is to add a bool logging = true; at the top of the f'n, and have the conditions that would have exited early use that to turn logging off? Let me know if you prefer that approach. WDYT?
Brady Eidson
Comment 3 2012-03-15 12:26:46 PDT
Comment on attachment 131971 [details] Patch This is just the logging method, this is fine.
Gavin Peters
Comment 4 2012-03-16 05:46:17 PDT
Comment on attachment 131971 [details] Patch Thanks Brady. I just had minor anxiety about the early exits, now the logic is colour-by-numbers identical to the fast nondebug version.
WebKit Review Bot
Comment 5 2012-03-16 06:25:47 PDT
Comment on attachment 131971 [details] Patch Clearing flags on attachment: 131971 Committed r110998: <http://trac.webkit.org/changeset/110998>
WebKit Review Bot
Comment 6 2012-03-16 06:25:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.