Bug 81164 – [Qt][WK2] QtWebKit2 should support Page Visibility API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Jesus Sanchez-Palencia]

We should implement the Page Visibility API support in QQuickWebView as soon as WebKit2 and WKTR have what is needed to it.

[Allan Sandfeld Jensen]

It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. 

A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized.

[Jesus Sanchez-Palencia]

(In reply to comment #1)
> It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. 
> 
> A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized.

With that in mind QWindow::isExposed and the whole new set of exposed events are being cooked, right?

Plus, why can't you use QQuickCanvas::windowStateChanged and check for Qt::WindowMinimized, for instance? (QQuickCanvas inherits QWindow).


cheers!

[Allan Sandfeld Jensen]

(In reply to comment #2)
> (In reply to comment #1)
> > It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. 
> > 
> > A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized.
> 
> With that in mind QWindow::isExposed and the whole new set of exposed events are being cooked, right?
> 
> Plus, why can't you use QQuickCanvas::windowStateChanged and check for Qt::WindowMinimized, for instance? (QQuickCanvas inherits QWindow).
> 
> 
QWindow doesn't have a windowStateChange. WindowState needs to be made into a property, or maybe that has already been done?

[Jesus Sanchez-Palencia]

Created attachment 135336 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 135336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135336&action=review

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:275
> +    if (m_webView->canvas() && m_webView->canvas()->windowState() == Qt::WindowMinimized)

Question is : when the isExposed will be ready? If it's a matter of little time, no need to check the workaround in no?

[Early Warning System Bot]

Comment on attachment 135336 [details]
Patch

Attachment 135336 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12324125

[Jesus Sanchez-Palencia]

Created attachment 135363 [details]
Patch

[WebKit Review Bot]

Comment on attachment 135363 [details]
Patch

Clearing flags on attachment: 135363

Committed r113183: <http://trac.webkit.org/changeset/113183>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.