WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81147
Typed Array create() methods do not accept const arrays
https://bugs.webkit.org/show_bug.cgi?id=81147
Summary
Typed Array create() methods do not accept const arrays
David Dorwin
Reported
2012-03-14 13:02:18 PDT
Many of the Typed Arrays (classes derived from TypedArrayBase) do not allow a pointer to a const array to be passed to the create method. For example: static inline PassRefPtr<Uint8Array> create(unsigned char* array, unsigned length); These methods use static PassRefPtr<Subclass> create(const T* array, unsigned length) so there is no reason the type of the first parameter cannot be const. The example above should be: static inline PassRefPtr<Uint8Array> create(const unsigned char* array, unsigned length);
Attachments
Patch
(9.78 KB, patch)
2012-03-14 13:20 PDT
,
David Dorwin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Dorwin
Comment 1
2012-03-14 13:20:52 PDT
Created
attachment 131908
[details]
Patch
Kenneth Russell
Comment 2
2012-03-14 16:38:02 PDT
Comment on
attachment 131908
[details]
Patch Thanks for fixing this. r=me
WebKit Review Bot
Comment 3
2012-03-15 16:58:49 PDT
Comment on
attachment 131908
[details]
Patch Clearing flags on attachment: 131908 Committed
r110913
: <
http://trac.webkit.org/changeset/110913
>
WebKit Review Bot
Comment 4
2012-03-15 16:58:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug