Bug 81132 - Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
Summary: Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 10:24 PDT by Peter Rybin
Modified: 2012-03-15 09:45 PDT (History)
10 users (show)

See Also:

Attachments
Patch (29.17 KB, patch)
2012-03-14 11:26 PDT, Peter Rybin 		no flags Details | Formatted Diff | Diff
Patch (29.14 KB, patch)
2012-03-14 15:52 PDT, Peter Rybin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-03-14 10:24:21 PDT 
Throughout inspector codebase most of .cpp file contain ENABLE(INSPECTOR) guards. However corresponding .h files are often included before this guard, i.e. unconditionally. There is a strange implication here that .h files should turn out to be compilable even when INSPECTOR is no enabled.
Since this implication often becomes wrong with development going on, all .h files should go behind ENABLE(INSPECTOR) guards.
Comment 1 Peter Rybin 2012-03-14 11:26:31 PDT 
Created attachment 131889 [details]
Patch
Comment 2 Peter Rybin 2012-03-14 15:52:17 PDT 
Created attachment 131944 [details]
Patch
Comment 3 Yury Semikhatsky 2012-03-15 09:44:54 PDT 
Comment on attachment 131944 [details]
Patch

Clearing flags on attachment: 131944

Committed r110854: <http://trac.webkit.org/changeset/110854>
Comment 4 Yury Semikhatsky 2012-03-15 09:45:21 PDT 
All reviewed patches have been landed.  Closing bug.