Bug 81124 – [EFL] Implement LayoutTestController::setEditingBehavior

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

Implement LayoutTestController::setEditingBehavior for EFL port so that we can unskip related tests from the skip list.

[Sudarsana Nagineni (babu)]

Created attachment 131870 [details]
Implement setEditingBehavior

[Gyuyoung Kim]

Comment on attachment 131870 [details]
Implement setEditingBehavior

Attachment 131870 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11953551

[Gyuyoung Kim]

Comment on attachment 131870 [details]
Implement setEditingBehavior

View in context: https://bugs.webkit.org/attachment.cgi?id=131870&action=review

> LayoutTests/platform/efl/Skipped:736
> +# Set unicode backspace value in EFL's createKeyMaap

Minor nit : %s/createKeyMaap/createKeyMap/g

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722
> +        ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN);

EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared.

[Sudarsana Nagineni (babu)]

(In reply to comment #3)

Thanks for your review!

> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722
> > +        ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN);
> 
> EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared.

This is dependent on bug #80126 fix.

[Raphael Kubo da Costa (:rakuco)]

*** Bug 80126 has been marked as a duplicate of this bug. ***

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> *** Bug 80126 has been marked as a duplicate of this bug. ***

As discussed in bug 80126, we're not adding anything to ewk_view anymore; instead, we're just adding some API to DumpRenderTreeSupportEfl. As it's all related to setEditingBehavior, it makes more sense to land everything in a single patch.

[Sudarsana Nagineni (babu)]

Created attachment 133087 [details]
Patch

Merged 80126 fix into this one.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 133087 [details]
Patch

Looks fine, thanks.

[Martin Robinson]

Comment on attachment 133087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133087&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:428
> +    else
> +        return;

Maybe it would be good to put an ASSERT_NOT_REACHED here?

[Sudarsana Nagineni (babu)]

Created attachment 133263 [details]
Patch

fixed comment #9.

[WebKit Review Bot]

Comment on attachment 133263 [details]
Patch

Clearing flags on attachment: 133263

Committed r111709: <http://trac.webkit.org/changeset/111709>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.