Bug 81107 - [Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
Summary: [Qt] RenderThemeQt::fileListNameForWidth should override function in base cla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 07:52 PDT by Zeno Albisser
Modified: 2012-03-15 16:29 PDT (History)
0 users

See Also:


Attachments
patch for review. (2.31 KB, patch)
2012-03-14 08:13 PDT, Zeno Albisser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-03-14 07:52:48 PDT
RenderThemeQt::fileListNameForWidth() misses a parameter to properly override RenderTheme::fileListNameForWidth().
This becomes obvious after r110560 where the OVERRIDE keyword has been added to the function declaration.
fileListNameForWidth() is only called in one place (WebCore/rendering/RenderFileUploadControl.cpp:244) and there it is called with the currently missing parameter "bool multipleFilesAllowed".
Therefore we can assume that the implementation RenderThemeQt::fileListNameForWidth() never actually happens to be called currently.
Comment 1 Zeno Albisser 2012-03-14 08:13:10 PDT
Created attachment 131850 [details]
patch for review.
Comment 2 Zeno Albisser 2012-03-15 16:29:12 PDT
Comment on attachment 131850 [details]
patch for review.

Clearing flags on attachment: 131850

Committed r110907: <http://trac.webkit.org/changeset/110907>
Comment 3 Zeno Albisser 2012-03-15 16:29:24 PDT
All reviewed patches have been landed.  Closing bug.