WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81105
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105
Summary
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
Nima Ghanavatian
Reported
2012-03-14 07:42:43 PDT
This is a consolidation of various changes that are in our local dev branch but do not appear in our upstreamed port.
Attachments
Patch
(16.86 KB, patch)
2012-03-14 08:24 PDT
,
Nima Ghanavatian
no flags
Details
Formatted Diff
Diff
Patch
(10.98 KB, patch)
2012-03-16 08:33 PDT
,
Nima Ghanavatian
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1
2012-03-14 08:24:41 PDT
Created
attachment 131856
[details]
Patch
Rob Buis
Comment 2
2012-03-14 08:30:30 PDT
Comment on
attachment 131856
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=131856&action=review
> Source/WebKit/blackberry/Api/WebPage.cpp:197 > + return WebCore::PlatformEvent::MousePressed;
The WebCore:: prefix is probably not needed, but we can do that cleanup later.
Rob Buis
Comment 3
2012-03-14 08:31:46 PDT
Comment on
attachment 131856
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=131856&action=review
LGTM.
>> Source/WebKit/blackberry/Api/WebPage.cpp:197 >> + return WebCore::PlatformEvent::MousePressed; > > The WebCore:: prefix is probably not needed, but we can do that cleanup later.
The WebCore:: prefix is probably not needed, but we can do that cleanup later.
WebKit Review Bot
Comment 4
2012-03-14 10:05:22 PDT
Comment on
attachment 131856
[details]
Patch Clearing flags on attachment: 131856 Committed
r110712
: <
http://trac.webkit.org/changeset/110712
>
WebKit Review Bot
Comment 5
2012-03-14 10:05:26 PDT
All reviewed patches have been landed. Closing bug.
Nima Ghanavatian
Comment 6
2012-03-16 08:33:31 PDT
Reopening to attach new patch.
Nima Ghanavatian
Comment 7
2012-03-16 08:33:34 PDT
Created
attachment 132290
[details]
Patch
Rob Buis
Comment 8
2012-03-16 08:47:33 PDT
Comment on
attachment 132290
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=132290&action=review
> Source/WebKit/blackberry/Api/BackingStore.cpp:2596 > + WebCore::IntRect(WebCore::IntPoint(0, 0), m_webPage->d->transformedViewportSize()));
You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.
Rob Buis
Comment 9
2012-03-16 09:09:54 PDT
Comment on
attachment 132290
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=132290&action=review
Looks good. Note that we can remove some WebCore:: prefixes, but that can be done in a later patch.
>> Source/WebKit/blackberry/Api/BackingStore.cpp:2596 >> + WebCore::IntRect(WebCore::IntPoint(0, 0), m_webPage->d->transformedViewportSize())); > > You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.
You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.
WebKit Review Bot
Comment 10
2012-03-16 10:17:16 PDT
Comment on
attachment 132290
[details]
Patch Clearing flags on attachment: 132290 Committed
r111024
: <
http://trac.webkit.org/changeset/111024
>
WebKit Review Bot
Comment 11
2012-03-16 10:17:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug