Bug 81105 - [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
Summary: [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 07:42 PDT by Nima Ghanavatian
Modified: 2012-03-16 10:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.86 KB, patch)
2012-03-14 08:24 PDT, Nima Ghanavatian
no flags Details | Formatted Diff | Diff
Patch (10.98 KB, patch)
2012-03-16 08:33 PDT, Nima Ghanavatian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-03-14 07:42:43 PDT
This is a consolidation of various changes that are in our local dev branch but do not appear in our upstreamed port.
Comment 1 Nima Ghanavatian 2012-03-14 08:24:41 PDT
Created attachment 131856 [details]
Patch
Comment 2 Rob Buis 2012-03-14 08:30:30 PDT
Comment on attachment 131856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131856&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:197
> +        return WebCore::PlatformEvent::MousePressed;

The WebCore:: prefix is probably not needed, but we can do that cleanup later.
Comment 3 Rob Buis 2012-03-14 08:31:46 PDT
Comment on attachment 131856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131856&action=review

LGTM.

>> Source/WebKit/blackberry/Api/WebPage.cpp:197
>> +        return WebCore::PlatformEvent::MousePressed;
> 
> The WebCore:: prefix is probably not needed, but we can do that cleanup later.

The WebCore:: prefix is probably not needed, but we can do that cleanup later.
Comment 4 WebKit Review Bot 2012-03-14 10:05:22 PDT
Comment on attachment 131856 [details]
Patch

Clearing flags on attachment: 131856

Committed r110712: <http://trac.webkit.org/changeset/110712>
Comment 5 WebKit Review Bot 2012-03-14 10:05:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Nima Ghanavatian 2012-03-16 08:33:31 PDT
Reopening to attach new patch.
Comment 7 Nima Ghanavatian 2012-03-16 08:33:34 PDT
Created attachment 132290 [details]
Patch
Comment 8 Rob Buis 2012-03-16 08:47:33 PDT
Comment on attachment 132290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132290&action=review

> Source/WebKit/blackberry/Api/BackingStore.cpp:2596
> +        WebCore::IntRect(WebCore::IntPoint(0, 0), m_webPage->d->transformedViewportSize()));

You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.
Comment 9 Rob Buis 2012-03-16 09:09:54 PDT
Comment on attachment 132290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132290&action=review

Looks good. Note that we can remove some WebCore:: prefixes, but that can be done in a later patch.

>> Source/WebKit/blackberry/Api/BackingStore.cpp:2596
>> +        WebCore::IntRect(WebCore::IntPoint(0, 0), m_webPage->d->transformedViewportSize()));
> 
> You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.

You don't have to fix it in this patch, but indenting is strange. We also prefer IntPoint::zero.
Comment 10 WebKit Review Bot 2012-03-16 10:17:16 PDT
Comment on attachment 132290 [details]
Patch

Clearing flags on attachment: 132290

Committed r111024: <http://trac.webkit.org/changeset/111024>
Comment 11 WebKit Review Bot 2012-03-16 10:17:21 PDT
All reviewed patches have been landed.  Closing bug.