Bug 81100 - Web Inspector: use class name indexes instead of class names when evaluating aggregates
Summary: Web Inspector: use class name indexes instead of class names when evaluating ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 06:20 PDT by Yury Semikhatsky
Modified: 2012-03-14 09:20 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.67 KB, patch)
2012-03-14 06:25 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2012-03-14 08:50 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-03-14 06:20:48 PDT
Use class name indexes instead of class names when evaluating aggregates. Class name lookup followed by string comparison takes significantly longer time then comparison of the class name indexes. For node type comparison it is also much faster to compare its integer value instead of strings.
Comment 1 Yury Semikhatsky 2012-03-14 06:25:06 PDT
Created attachment 131835 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-14 06:56:10 PDT
Comment on attachment 131835 [details]
Patch

Please ignore this patch.
Comment 3 Yury Semikhatsky 2012-03-14 08:50:58 PDT
Created attachment 131863 [details]
Patch
Comment 4 Yury Semikhatsky 2012-03-14 08:52:25 PDT
This patch makes _buildAggregates ~ 35% faster.
Comment 5 Ilya Tikhonovsky 2012-03-14 08:58:16 PDT
Comment on attachment 131863 [details]
Patch

lgtm
Comment 6 Yury Semikhatsky 2012-03-14 09:20:53 PDT
Committed r110707: <http://trac.webkit.org/changeset/110707>