Bug 81087 - Don't install libWebCoreTestSupport on OS X production builds
Summary: Don't install libWebCoreTestSupport on OS X production builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Matt Lilek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-03-14 00:46 PDT by Matt Lilek
Modified: 2012-03-16 13:48 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.23 KB, patch)
2012-03-14 00:53 PDT, Matt Lilek
mrowe: review-
dev+webkit: commit-queue-
Details | Formatted Diff | Diff
patch2 (1.27 KB, patch)
2012-03-16 13:39 PDT, Matt Lilek
mrowe: review+
dev+webkit: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2012-03-14 00:46:11 PDT
No reason to install this dylib on production builds.

<rdar://problem/10501894>
Comment 1 Matt Lilek 2012-03-14 00:53:08 PDT
Created attachment 131801 [details]
patch
Comment 2 Mark Rowe (bdash) 2012-03-14 01:14:42 PDT
Comment on attachment 131801 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131801&action=review

> Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:35
> +SKIP_INSTALL = $(SKIP_INSTALL_$(BUILD_TYPE));
> +SKIP_INSTALL_Production = YES;

I don't know what BUILD_TYPE is. It wouldn't be what we want anyway. Since this library is only used by DumpRenderTree and friends we want this installed only when FORCE_TOOL_INSTALL = YES. See Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig for where we do this elsewhere.
Comment 3 Matt Lilek 2012-03-15 15:38:18 PDT
BUILD_TYPE was a typo.  But the way ToolExecutable does it is even better.  New patch forthcoming.
Comment 4 Matt Lilek 2012-03-16 13:39:09 PDT
Created attachment 132362 [details]
patch2
Comment 5 Matt Lilek 2012-03-16 13:48:35 PDT
http://trac.webkit.org/changeset/111058