Bug 81083 – [Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Hajime Morrita]

The unit test fails since http://trac.webkit.org/changeset/110596
http://chromegw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%281%29/builds/10820

---
CCQuadCullerTest.verifyCullChildLinesUpTopLeft: 
Did not complete.
---

[Hajime Morrita]

Marked as fails at http://trac.webkit.org/changeset/110666

[Dana Jansens]

Created attachment 131847 [details]
Patch

[Adrienne Walker]

Comment on attachment 131847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131847&action=review

> Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:48
> +        m_stack.last().surface = 0;

Can you enforce that StackObject doesn't leave surface uninitialized so this doesn't happen again? Maybe add a default constructor that initializes to null and some other constructor that initializes to some other surface?

[Dana Jansens]

(In reply to comment #3)
> (From update of attachment 131847 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131847&action=review
> 
> > Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:48
> > +        m_stack.last().surface = 0;
> 
> Can you enforce that StackObject doesn't leave surface uninitialized so this doesn't happen again? Maybe add a default constructor that initializes to null and some other constructor that initializes to some other surface?

Yup! Done.

[Dana Jansens]

Created attachment 131874 [details]
Patch

[Adrienne Walker]

Comment on attachment 131874 [details]
Patch

Thanks! R=me

[WebKit Review Bot]

Comment on attachment 131874 [details]
Patch

Clearing flags on attachment: 131874

Committed r110878: <http://trac.webkit.org/changeset/110878>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.