NEW 81059
Rebaseline server can't deal with platform-specific tests 
https://bugs.webkit.org/show_bug.cgi?id=81059
Summary Rebaseline server can't deal with platform-specific tests
Tim Horton
Reported 2012-03-13 16:59:43 PDT
I just tried to use the rebaseline server to rebaseline some tests in: platform/mac/fast/forms While I set the target platform to mac, it tried to put the results in: platform/mac/platform/mac/fast/forms This is wrong. It looks like someone (Simon and Dan) might have accidentally checked in results here in the past, too (potentially one of the other rebaselining tools also has this bug?).
Attachments
Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-03-13 17:03:30 PDT
It’s arguably correct for platform-specific results (such as images and render tree output) for platform-specific tests to be in that location. I think the “old” run-webkit-tests script also followed this convention.
Alexey Proskuryakov
Comment 2 2012-03-13 17:11:59 PDT
It may be useful when e.g. a platform/mac test has results that depend on OS X version (or on whether it's WK2 or WK1). However, this doesn't seem to be a meaningful default.
Dirk Pranke
Comment 3 2012-03-13 17:30:07 PDT
to clarify: "rebaseline server" == 'webkit-patch rebaseline-server"? I don't actually know how well supported that tool is at the moment, so consider yourself warned. Apart from that, I am not surprised by this - we put new baselines in the platform-specific directory by default, so putting the baseline for a platform-specific test in the platform-specific directory for that test is consistent. Which is not necessarily saying that it's right :). For comparison, with old-run-webkit-tests, for platform-independent tests, I believe new baselines would be written into platform/mac by default, platform/mac-lion (or whatever version as appropriate) with --add-platform-exceptions, and into the generic directory with --reset-results. I don't know what it did with platform-specific tests. I believe new-run-webkit-tests uses --new-baseline instead of --add-platform-exceptions. I would expect it to treat platform-specific tests the same as platform-independent tests. I could be wrong about both of these (haven't tested the behavior). Ideally 'webkit-patch rebaseline-server' and 'new-run-webkit-tests' would have the same behavior and use the same set of command line flags to change behavior. If there is agreement on how we want it to work, I'll be happy to implement whatever. Can someone please propose a full strawman for this?
Note You need to log in before you can comment on or make changes to this bug.