Bug 81055 - Heap::destroy leaks CopiedSpace
Summary: Heap::destroy leaks CopiedSpace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 16:27 PDT by Mark Hahnenberg
Modified: 2012-03-14 14:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.41 KB, patch)
2012-03-13 18:07 PDT, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-03-13 16:27:06 PDT
Currently we do not do anything to clean up memory in the CopiedSpace in Heap::destroy. We should add a destroy() function to CopiedSpace to remedy this.
Comment 1 Mark Hahnenberg 2012-03-13 16:27:22 PDT
<rdar://problem/11041460>
Comment 2 Mark Hahnenberg 2012-03-13 18:07:07 PDT
Created attachment 131766 [details]
Patch
Comment 3 Geoffrey Garen 2012-03-14 12:39:58 PDT
Comment on attachment 131766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131766&action=review

> Source/JavaScriptCore/heap/Heap.cpp:383
> +    m_storageSpace.destroy();

This should move above the size() ASSERT.
Comment 4 Mark Hahnenberg 2012-03-14 14:14:28 PDT
Committed r110748: <http://trac.webkit.org/changeset/110748>