Bug 81046 – Improve filter-build-webkit, especially for iOS builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dean Jackson]

I'll collect the rules that are missing from fbwk here, and commit when we're happy.

The first one:
jsc: replacing existing signature

[Dean Jackson]

This is producing some output:
PhaseScriptExecution Copy WTF Headers

For example:

PhaseScriptExecution Copy WTF Headers
building file list ... done
./
Stub.h
config.h
icu/
icu/unicode/
icu/unicode/parseerr.h
icu/unicode/platform.h
icu/unicode/putil.h
icu/unicode/uchar.h
icu/unicode/ucnv.h
icu/unicode/ucnv_err.h
icu/unicode/ucol.h
icu/unicode/uconfig.h
icu/unicode/uenum.h
icu/unicode/uiter.h
icu/unicode/uloc.h
icu/unicode/umachine.h
icu/unicode/unorm.h
icu/unicode/urename.h
icu/unicode/uscript.h
icu/unicode/uset.h
icu/unicode/ustring.h
icu/unicode/utf.h
icu/unicode/utf16.h
icu/unicode/utf8.h
icu/unicode/utf_old.h
icu/unicode/utypes.h
icu/unicode/uversion.h
sent 614838 bytes  received 588 bytes  1230852.00 bytes/sec
total size is 613144  speedup is 1.00

[Dean Jackson]

And when it runs again, you get something like this:


PhaseScriptExecution Copy WTF Headers
building file list ... done
sent 4573 bytes  received 20 bytes  9186.00 bytes/sec
total size is 1208643  speedup is 263.15

[Dean Jackson]

PhaseScriptExecution Generate Derived Sources
/Developer/usr/bin/bison -d -p cssyy WebCore/css/CSSGrammar.y -o CSSGrammar.cpp
/Developer/usr/bin/bison -d -p xpathyy WebCore/xml/XPathGrammar.y -o XPathGrammar.cpp

[Dean Jackson]

I'm not sure how many of these are still relevant, but I have a big update coming and I don't see nearly as much crappy output.

[Dean Jackson]

Created attachment 221306 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 221306 [details]
Patch

Looks good to me!

[Dirk Schulze]

Did that land?

[Joseph Pecoraro]

Looks like it did: r162090 <http://trac.webkit.org/changeset/162090>

[Joseph Pecoraro]

Comment on attachment 221306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221306&action=review

> Tools/Scripts/filter-build-webkit:147
> +        $path =~ s/("|\\|\.[oah]$)//g;

Though I would like to have the .o's back. Not sure about .a/.h.