WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81044
Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044
Summary
Support loading a WKPage from web archive data
Jeff Miller
Reported
2012-03-13 15:32:28 PDT
Support loading a WKPage from web archive data
Attachments
Patch
(6.31 KB, patch)
2012-03-13 15:37 PDT
,
Jeff Miller
no flags
Details
Formatted Diff
Diff
Patch
(6.25 KB, patch)
2012-03-13 16:35 PDT
,
Jeff Miller
beidson
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jeff Miller
Comment 1
2012-03-13 15:37:50 PDT
Created
attachment 131730
[details]
Patch
Brady Eidson
Comment 2
2012-03-13 15:42:39 PDT
Comment on
attachment 131730
[details]
Patch I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData"
Jeff Miller
Comment 3
2012-03-13 15:44:55 PDT
(In reply to
comment #2
)
> (From update of
attachment 131730
[details]
) > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData"
Sounds reasonable. New patch soon.
Jessie Berlin
Comment 4
2012-03-13 15:45:34 PDT
> (From update of
attachment 131730
[details]
) > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData"
I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData".
Jeff Miller
Comment 5
2012-03-13 15:47:35 PDT
(In reply to
comment #4
)
> > (From update of
attachment 131730
[details]
[details]) > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData".
OK. I eagerly await their opinions.
Brady Eidson
Comment 6
2012-03-13 15:49:18 PDT
(In reply to
comment #4
)
> > (From update of
attachment 131730
[details]
[details]) > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData".
I'm suggesting "WKLoadWebArchiveData" I don't think the current "WKLoadWebArchiveFromData" flows very well or follows naming precedent. I think "WKLoadWebArchiveForData" doesn't make any sense at all!
mitz
Comment 7
2012-03-13 16:24:12 PDT
(In reply to
comment #6
)
> (In reply to
comment #4
) > > > (From update of
attachment 131730
[details]
[details] [details]) > > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". > > I'm suggesting "WKLoadWebArchiveData"
I think you mean WK*Page*LoadWebArchiveData.
Jeff Miller
Comment 8
2012-03-13 16:35:33 PDT
Created
attachment 131749
[details]
Patch
Jeff Miller
Comment 9
2012-03-13 16:36:07 PDT
I agree with Brady, I've attached a new patch.
Brady Eidson
Comment 10
2012-03-13 16:37:26 PDT
(In reply to
comment #7
)
> (In reply to
comment #6
) > > (In reply to
comment #4
) > > > > (From update of
attachment 131730
[details]
[details] [details] [details]) > > > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > > > > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". > > > > I'm suggesting "WKLoadWebArchiveData" > > I think you mean WK*Page*LoadWebArchiveData.
Yes, sure did.
Jeff Miller
Comment 11
2012-03-13 16:39:22 PDT
Committed
r110638
: <
http://trac.webkit.org/changeset/110638
>
Sam Weinig
Comment 12
2012-03-13 18:28:22 PDT
This patch is missing API tests. Please add them.
Jeff Miller
Comment 13
2012-03-13 21:04:26 PDT
(In reply to
comment #12
)
> This patch is missing API tests. Please add them.
I wrote up
bug 81073
to track this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug