Support loading a WKPage from web archive data
Created attachment 131730 [details] Patch
Comment on attachment 131730 [details] Patch I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData"
(In reply to comment #2) > (From update of attachment 131730 [details]) > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" Sounds reasonable. New patch soon.
> (From update of attachment 131730 [details]) > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData".
(In reply to comment #4) > > (From update of attachment 131730 [details] [details]) > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". OK. I eagerly await their opinions.
(In reply to comment #4) > > (From update of attachment 131730 [details] [details]) > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". I'm suggesting "WKLoadWebArchiveData" I don't think the current "WKLoadWebArchiveFromData" flows very well or follows naming precedent. I think "WKLoadWebArchiveForData" doesn't make any sense at all!
(In reply to comment #6) > (In reply to comment #4) > > > (From update of attachment 131730 [details] [details] [details]) > > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". > > I'm suggesting "WKLoadWebArchiveData" I think you mean WK*Page*LoadWebArchiveData.
Created attachment 131749 [details] Patch
I agree with Brady, I've attached a new patch.
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > > (From update of attachment 131730 [details] [details] [details] [details]) > > > > I'd rather see every instance of "WebArchiveFromData" be "WebArchiveData" > > > > > > I think that naming came from Sam and Anders (loadWebArchiveFromData). It might have been "ForData". > > > > I'm suggesting "WKLoadWebArchiveData" > > I think you mean WK*Page*LoadWebArchiveData. Yes, sure did.
Committed r110638: <http://trac.webkit.org/changeset/110638>
This patch is missing API tests. Please add them.
(In reply to comment #12) > This patch is missing API tests. Please add them. I wrote up bug 81073 to track this.