IndexedDB Tests: use self instead of window
Created attachment 131725 [details] Patch
Created attachment 131732 [details] Patch
Created attachment 131735 [details] Patch
Josh, could you take a look at this patch? It is pipelined on top of the patch in bug 80664. I think the only even somewhat interesting bits of this patch are in factory-deletedatabase-interactions.html and open-close-version.html where 'self' was already used to stash a copy of the 'this' pointer. I changed it to 'that'. Some of these tests use self.document and the like, which won't work in workers, but I'll change those when those tests actually start to run in workers.
Comment on attachment 131735 [details] Patch LGTM - just notes below for other readers. View in context: https://bugs.webkit.org/attachment.cgi?id=131735&action=review > LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html:18 > + name = self.location.pathname; Cool - I didn't know workers had |location|. :) > LayoutTests/storage/indexeddb/factory-cmp.html:121 > + "self.document", As noted in dgrogan's comment, this will fail in workers. The intent of this is to exercise some invalid keys by using host objects. "self.document" could be changed to "self.location" and "self.document.body" with no loss of fidelity to the test, but this can wait for a followup patch. > LayoutTests/storage/indexeddb/invalid-keys.html:-59 > - "window.document", // HTMLDocument Ditto. > LayoutTests/storage/indexeddb/key-type-array.html:168 > + "[ self.document ]", Ditto. > LayoutTests/storage/indexeddb/structured-clone.html:534 > evalAndExpectException("store.put(document, 'key')", "DOMException.DATA_CLONE_ERR"); Ditto, although porting this test to workers will prove tricky due to Blob/File/FileList usage.
Created attachment 131945 [details] Patch
Comment on attachment 131945 [details] Patch Attachment 131945 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11956438 New failing tests: storage/indexeddb/set_version_queue.html
Created attachment 131985 [details] Patch
Tony, could you review this?
Comment on attachment 131985 [details] Patch rs=me
Comment on attachment 131985 [details] Patch Clearing flags on attachment: 131985 Committed r110931: <http://trac.webkit.org/changeset/110931>
All reviewed patches have been landed. Closing bug.