Bug 81030 - Move DOMWindowFileSystem to Modules/filesystem/
Summary: Move DOMWindowFileSystem to Modules/filesystem/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 13:33 PDT by Mark Pilgrim (Google)
Modified: 2012-03-16 00:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (30.95 KB, patch)
2012-03-13 13:34 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (39.73 KB, patch)
2012-03-13 15:25 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (40.15 KB, patch)
2012-03-13 15:40 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (39.16 KB, patch)
2012-03-15 10:23 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-03-13 13:33:31 PDT 
Move DOMWindowFileSystem to Modules/filesystem/
Comment 1 Mark Pilgrim (Google) 2012-03-13 13:34:28 PDT 
Created attachment 131705 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-03-13 13:47:22 PDT 
Comment on attachment 131705 [details]
Patch

CQ once EWS bots pass?
Comment 3 Adam Barth 2012-03-13 13:50:54 PDT 
Will do.

One really minor nit: WebKit uses case-sensitive sorting, so upper case letters always appear before lowercase letters.  It's not worth re-spinning this patch, but I thought I should mention it.
Comment 4 Build Bot 2012-03-13 14:08:23 PDT 
Comment on attachment 131705 [details]
Patch

Attachment 131705 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11943704
Comment 5 Mark Pilgrim (Google) 2012-03-13 15:25:56 PDT 
Created attachment 131726 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2012-03-13 15:28:34 PDT 
New patch also includes changes to WebCore.vcproj/copyForwardingHeaders.cmd and WebCore.vcproj/WebCoreCommon.vsprops, which have been added to my private list of 
"top ten build files that might need to be changed when moving a single file from one directory to another."
Comment 7 Kentaro Hara 2012-03-13 15:32:40 PDT 
Comment on attachment 131726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131726&action=review

> Source/WebCore/Target.pri:410
> +    Modules/filesystem/DirectoryEntry.cpp \
> +    Modules/filesystem/DirectoryEntrySync.cpp \
> +    Modules/filesystem/DirectoryReader.cpp \
> +    Modules/filesystem/DirectoryReaderSync.cpp \
> +    Modules/filesystem/DOMWindowFileSystem.cpp \

Nit: As Adam pointed out, DOMWindowFileSystem.cpp should come first in the case-sensitive alphabetical order.

> Source/WebCore/WebCore.gypi:728
> +            'Modules/filesystem/DOMWindowFileSystem.idl',

Ditto.

> Source/WebCore/WebCore.gypi:1304
> +            'Modules/filesystem/DOMWindowFileSystem.h',

Ditto.
Comment 8 Mark Pilgrim (Google) 2012-03-13 15:40:07 PDT 
Created attachment 131731 [details]
Patch
Comment 9 Mark Pilgrim (Google) 2012-03-13 15:40:34 PDT 
Comment on attachment 131731 [details]
Patch

Nits addressed.
Comment 10 WebKit Review Bot 2012-03-14 15:03:50 PDT 
Comment on attachment 131731 [details]
Patch

Rejecting attachment 131731 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Source/WebCore/fileapi/DOMWindowFileSystem.cpp
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.cpp'
patching file Source/WebCore/fileapi/DOMWindowFileSystem.h
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.h'
patching file Source/WebCore/fileapi/DOMWindowFileSystem.idl
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.idl'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11957227
Comment 11 Mark Pilgrim (Google) 2012-03-15 10:23:25 PDT 
Created attachment 132072 [details]
Patch
Comment 12 WebKit Review Bot 2012-03-16 00:44:35 PDT 
Comment on attachment 132072 [details]
Patch

Clearing flags on attachment: 132072

Committed r110957: <http://trac.webkit.org/changeset/110957>
Comment 13 WebKit Review Bot 2012-03-16 00:44:53 PDT 
All reviewed patches have been landed.  Closing bug.