Bug 81030 – Move DOMWindowFileSystem to Modules/filesystem/

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

Move DOMWindowFileSystem to Modules/filesystem/

[Mark Pilgrim (Google)]

Created attachment 131705 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 131705 [details]
Patch

CQ once EWS bots pass?

[Adam Barth]

Will do.

One really minor nit: WebKit uses case-sensitive sorting, so upper case letters always appear before lowercase letters.  It's not worth re-spinning this patch, but I thought I should mention it.

[Build Bot]

Comment on attachment 131705 [details]
Patch

Attachment 131705 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11943704

[Mark Pilgrim (Google)]

Created attachment 131726 [details]
Patch

[Mark Pilgrim (Google)]

New patch also includes changes to WebCore.vcproj/copyForwardingHeaders.cmd and WebCore.vcproj/WebCoreCommon.vsprops, which have been added to my private list of 
"top ten build files that might need to be changed when moving a single file from one directory to another."

[Kentaro Hara]

Comment on attachment 131726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131726&action=review

> Source/WebCore/Target.pri:410
> +    Modules/filesystem/DirectoryEntry.cpp \
> +    Modules/filesystem/DirectoryEntrySync.cpp \
> +    Modules/filesystem/DirectoryReader.cpp \
> +    Modules/filesystem/DirectoryReaderSync.cpp \
> +    Modules/filesystem/DOMWindowFileSystem.cpp \

Nit: As Adam pointed out, DOMWindowFileSystem.cpp should come first in the case-sensitive alphabetical order.

> Source/WebCore/WebCore.gypi:728
> +            'Modules/filesystem/DOMWindowFileSystem.idl',

Ditto.

> Source/WebCore/WebCore.gypi:1304
> +            'Modules/filesystem/DOMWindowFileSystem.h',

Ditto.

[Mark Pilgrim (Google)]

Created attachment 131731 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 131731 [details]
Patch

Nits addressed.

[WebKit Review Bot]

Comment on attachment 131731 [details]
Patch

Rejecting attachment 131731 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Source/WebCore/fileapi/DOMWindowFileSystem.cpp
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.cpp'
patching file Source/WebCore/fileapi/DOMWindowFileSystem.h
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.h'
patching file Source/WebCore/fileapi/DOMWindowFileSystem.idl
rm 'Source/WebCore/fileapi/DOMWindowFileSystem.idl'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11957227

[Mark Pilgrim (Google)]

Created attachment 132072 [details]
Patch

[WebKit Review Bot]

Comment on attachment 132072 [details]
Patch

Clearing flags on attachment: 132072

Committed r110957: <http://trac.webkit.org/changeset/110957>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.