Bug 81024 – fast/loader/form-submission-after-beforeunload-cancel.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Darin Fisher (:fishd, Google)]

fast/loader/form-submission-after-beforeunload-cancel.html is flaky

On my system, it sometimes fails like this:

 CONFIRM NAVIGATION: Click 'Stay on Page'
-CONFIRM NAVIGATION: Click 'Leave Page'
-PASS
+This tests that submitting a form a second time after canceling the first submission in a onbeforeunload handler is allowed. To test manually, follow the instructions in the JavaScript confirmation dialogs.
+
+FAIL
+

It looks like there is a race between the network stack (file:// loading) and the setTimeout(..., 0) that stamps the FAIL text.

[Darin Fisher (:fishd, Google)]

Also, when the test fails, the next test run by DRT ends up with the following text prepended:

  CONFIRM NAVIGATION: Click 'Leave Page'
  PASS

This suggests that the setTimeout code is running, trigging the notifyDone(), and then the form submission goes through.

[Darin Fisher (:fishd, Google)]

Created attachment 131702 [details]
v1 patch:  increase timeout

I'm not a big fan of patches like this.  Obviously, disk reads could still
in exceptional cases take longer than 1 second, but this makes the test
far more stable.

[Andy Estes]

Comment on attachment 131702 [details]
v1 patch:  increase timeout

The one second timeout is indeed unfortunate, but since it only applies to the failure case and gets rid of the flakiness, this seems okay.

[WebKit Review Bot]

Comment on attachment 131702 [details]
v1 patch:  increase timeout

Clearing flags on attachment: 131702

Committed r110633: <http://trac.webkit.org/changeset/110633>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.