Bug 81017 - Revert RenderLayer::absoluteBoundingBox to an IntRect
Summary: Revert RenderLayer::absoluteBoundingBox to an IntRect
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2012-03-13 11:55 PDT by Levi Weintraub
Modified: 2012-03-13 15:53 PDT (History)
6 users (show)

See Also:

Patch (3.44 KB, patch)
2012-03-13 12:16 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-03-13 11:55:16 PDT
RenderLayer::absoluteBoundingBox represents a layer's box in application coordinates and is used mostly by platform code. This change pixel snaps the rect and returns it as an IntRect to avoid exposing sub-pixel units to platform code, and because absolute coordinates make more senes to be in pixels (see also absoluteRects, which uses IntRect).
Comment 1 Levi Weintraub 2012-03-13 12:16:22 PDT
Created attachment 131690 [details]
Comment 2 Eric Seidel (no email) 2012-03-13 12:17:16 PDT
Comment on attachment 131690 [details]

Comment 3 Levi Weintraub 2012-03-13 12:17:47 PDT
Comment on attachment 131690 [details]

Thanks Eric :)
Comment 4 WebKit Review Bot 2012-03-13 15:53:50 PDT
Comment on attachment 131690 [details]

Clearing flags on attachment: 131690

Committed r110629: <http://trac.webkit.org/changeset/110629>
Comment 5 WebKit Review Bot 2012-03-13 15:53:55 PDT
All reviewed patches have been landed.  Closing bug.