Bug 81010 – REGRESSION(r110469): This patch still appears to crash (Requested by abarth on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/110469 broke the build:
This patch still appears to crash (Requested by abarth on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 131660 [details]
ROLLOUT of r110469

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Adam Barth]

We're seeing a similar set of crashes as when this patch landed previously.  I'm rolling it out to see if that fixes the crashes again.  Here are some of the crash stacks:

https://gist.github.com/2028708

[WebKit Review Bot]

Comment on attachment 131660 [details]
ROLLOUT of r110469

Clearing flags on attachment: 131660

Committed r110581: <http://trac.webkit.org/changeset/110581>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

s/crash/assertions

I'd love to see some help on getting these resolved, rather than just reverting every time.

[Nikolas Zimmermann]

(In reply to comment #5)
> s/crash/assertions
> 
> I'd love to see some help on getting these resolved, rather than just reverting every time.

Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :(

[Tim Horton]

(In reply to comment #6)
> (In reply to comment #5)
> > s/crash/assertions
> > 
> > I'd love to see some help on getting these resolved, rather than just reverting every time.
> 
> Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :(

Niko, is this rollout related to that? I thought this was separate (though still something I need help with).

[Nikolas Zimmermann]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > s/crash/assertions
> > > 
> > > I'd love to see some help on getting these resolved, rather than just reverting every time.
> > 
> > Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :(
> 
> Niko, is this rollout related to that? I thought this was separate (though still something I need help with).

Sorry, I mixed up the patches. Adam reverted the SVGImage patch, not the animVal patch.
The regressions due to the animVal patch should be fixed now, I landed the patch some minutes ago.

[Adam Barth]

> I'd love to see some help on getting these resolved, rather than just reverting every time.

I don't think I'll be much help in resolving this issue.  I don't know much about SVG or painting.  Maybe emailing webkit-dev would turn up someone who can help?

[Hajime Morrita]

(In reply to comment #9)
> > I'd love to see some help on getting these resolved, rather than just reverting every time.
> 
> I don't think I'll be much help in resolving this issue.  I don't know much about SVG or painting.  Maybe emailing webkit-dev would turn up someone who can help?

I'll take a look at this in next week since my local SL can have repro.