Bug 81008 - Region::contains(IntPoint) is slow
Summary: Region::contains(IntPoint) is slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 10:08 PDT by Dana Jansens
Modified: 2012-03-13 15:35 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2012-03-13 10:11 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (8.23 KB, patch)
2012-03-13 11:09 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (8.23 KB, patch)
2012-03-13 11:26 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (8.41 KB, patch)
2012-03-13 11:31 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (8.47 KB, patch)
2012-03-13 11:42 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-13 10:08:20 PDT
Region::contains(IntPoint) is slow
Comment 1 Dana Jansens 2012-03-13 10:11:19 PDT
Created attachment 131653 [details]
Patch
Comment 2 Dana Jansens 2012-03-13 11:09:43 PDT
Created attachment 131672 [details]
Patch
Comment 3 Dana Jansens 2012-03-13 11:26:19 PDT
Created attachment 131680 [details]
Patch

Removed the early-out on if (isEmpty()). The first for loop will break immediately anyhow, so this is just adding extra comparisons.
Comment 4 Anders Carlsson 2012-03-13 11:28:31 PDT
Comment on attachment 131680 [details]
Patch

Oops, meant to r- this. Could you add a more descriptive explanation in the ChangeLog? Other than that the change looks fine!
Comment 5 Dana Jansens 2012-03-13 11:31:46 PDT
Created attachment 131682 [details]
Patch
Comment 6 Dana Jansens 2012-03-13 11:42:22 PDT
Created attachment 131685 [details]
Patch
Comment 7 WebKit Review Bot 2012-03-13 15:35:30 PDT
Comment on attachment 131685 [details]
Patch

Clearing flags on attachment: 131685

Committed r110624: <http://trac.webkit.org/changeset/110624>
Comment 8 WebKit Review Bot 2012-03-13 15:35:35 PDT
All reviewed patches have been landed.  Closing bug.