Bug 81001 - [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
Summary: [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on:
Blocks: 79100
  Show dependency treegraph
 
Reported: 2012-03-13 09:07 PDT by Konrad Piascik
Modified: 2012-05-30 21:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (18.86 KB, patch)
2012-05-30 11:38 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff
Patch (18.72 KB, patch)
2012-05-30 12:36 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff
Patch (18.71 KB, patch)
2012-05-30 13:35 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-03-13 09:07:19 PDT
Chromium does this in bug 62149.  BlackBerry will add its own implementation in the hopes that once the 2 ports have visibility into each other's code that bug 79100 will be easier to address.
Comment 1 Konrad Piascik 2012-05-30 11:38:00 PDT
Created attachment 144882 [details]
Patch
Comment 2 Arvid Nilsson 2012-05-30 12:20:05 PDT
Comment on attachment 144882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144882&action=review

> Source/WebKit/ChangeLog:3
> +        [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight.

I think it should be "an accelerated..."

> Source/WebKit/blackberry/ChangeLog:3
> +        [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight.

Same here

> Source/WebKit/blackberry/Api/WebPage_p.h:431
> +#endif

I think this is a remnant from an earlier version of the patch, that you should remove.
Comment 3 Arvid Nilsson 2012-05-30 12:21:44 PDT
Otherwise looks good, I see you added a line to updateDelegatedOverlays, I hope it follows along with accelerated animations now...
Comment 4 Konrad Piascik 2012-05-30 12:30:26 PDT
update summary
Comment 5 Konrad Piascik 2012-05-30 12:36:30 PDT
Created attachment 144897 [details]
Patch
Comment 6 Antonio Gomes 2012-05-30 13:27:53 PDT
Comment on attachment 144897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144897&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6348
> +    }
> +
> +}

r- extra line :)
Comment 7 Konrad Piascik 2012-05-30 13:35:32 PDT
Created attachment 144911 [details]
Patch
Comment 8 WebKit Review Bot 2012-05-30 20:59:55 PDT
Comment on attachment 144911 [details]
Patch

Clearing flags on attachment: 144911

Committed r119046: <http://trac.webkit.org/changeset/119046>
Comment 9 WebKit Review Bot 2012-05-30 21:00:01 PDT
All reviewed patches have been landed.  Closing bug.