Bug 81000 - [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
Summary: [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using Animatio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-03-13 09:06 PDT by Andrew Lo
Modified: 2012-03-14 09:23 PDT (History)
4 users (show)

See Also:

patch #1 (12.72 KB, patch)
2012-03-13 15:04 PDT, Andrew Lo
no flags Details | Formatted Diff | Diff
Fixed style issues (12.77 KB, patch)
2012-03-13 15:35 PDT, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-03-13 09:06:23 PDT
Implement DisplayRefreshMonitor for the BlackBerry port, so that requestAnimationFrame uses the BlackBerry platform AnimationFrameRateController to signal frame changes.
Comment 1 Andrew Lo 2012-03-13 15:04:16 PDT
Created attachment 131721 [details]
patch #1
Comment 2 WebKit Review Bot 2012-03-13 15:08:49 PDT
Attachment 131721 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:77:  The parameter name "monitor" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:78:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 3 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrew Lo 2012-03-13 15:35:02 PDT
Created attachment 131728 [details]
Fixed style issues
Comment 4 WebKit Review Bot 2012-03-14 09:23:17 PDT
Comment on attachment 131728 [details]
Fixed style issues

Clearing flags on attachment: 131728

Committed r110709: <http://trac.webkit.org/changeset/110709>
Comment 5 WebKit Review Bot 2012-03-14 09:23:21 PDT
All reviewed patches have been landed.  Closing bug.