Bug 80983 - Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
Summary: Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 05:13 PDT by jochen
Modified: 2012-03-19 23:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.88 KB, patch)
2012-03-13 05:15 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-03-13 05:13:13 PDT 
Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
Comment 1 jochen 2012-03-13 05:15:35 PDT 
Created attachment 131593 [details]
Patch
Comment 2 jochen 2012-03-13 05:20:48 PDT 
Alexey, can you review this change?

During my debugging, I often use WTFGetBacktrace to store backtraces in various objects, and want to print the symbolized stack trace at some later point.
Comment 3 jochen 2012-03-14 01:53:09 PDT 
Adding Gavin and Balazs who both wrote that code, and Simon and Darin, who reviewed their changes
Comment 4 Gavin Peters 2012-03-14 04:54:16 PDT 
Comment on attachment 131593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131593&action=review

I'm not a reviewer, but I like this change.

> Source/JavaScriptCore/wtf/Assertions.cpp:-307
> -    for (int i = framesToSkip; i < frames; ++i) {

Nice to see framesToSkip leave the printing logic.
Comment 5 Balazs Kelemen 2012-03-14 07:11:54 PDT 
Seems reasonable to me (although I'm not a reviewer).
Comment 6 WebKit Review Bot 2012-03-19 23:48:34 PDT 
Comment on attachment 131593 [details]
Patch

Clearing flags on attachment: 131593

Committed r111366: <http://trac.webkit.org/changeset/111366>
Comment 7 WebKit Review Bot 2012-03-19 23:48:39 PDT 
All reviewed patches have been landed.  Closing bug.