Bug 80972 - Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
Summary: Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 00:50 PDT by Keishi Hattori
Modified: 2012-03-30 06:15 PDT (History)
10 users (show)

See Also:


Attachments
Patch (55.08 KB, patch)
2012-03-13 05:29 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (58.20 KB, patch)
2012-03-30 02:51 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (58.17 KB, patch)
2012-03-30 04:30 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-03-13 00:50:43 PDT
ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_COLOR both exist, so I'm unifying these flags to ENABLE_INPUT_TYPE_COLOR.
Comment 1 Keishi Hattori 2012-03-13 05:29:43 PDT
Created attachment 131595 [details]
Patch
Comment 2 Hajime Morrita 2012-03-15 22:57:34 PDT
Comment on attachment 131595 [details]
Patch

Don't forget updating the Wiki page tkent wrote.
Comment 3 Kent Tamura 2012-03-29 19:10:06 PDT
Comment on attachment 131595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131595&action=review

> Source/WebKit/chromium/features.gypi:-55
> -      'ENABLE_INPUT_COLOR=0',

Let's add ENABLE_INPUT_TYPE_COLOR=1
Comment 4 Keishi Hattori 2012-03-30 02:51:09 PDT
Created attachment 134757 [details]
Patch
Comment 5 Kent Tamura 2012-03-30 02:57:51 PDT
Comment on attachment 134757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134757&action=review

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:168
> -#if ENABLE(INPUT_COLOR)
> +#if ENABLE_INPUT_TYPE_COLOR

Isn't it ENABLE(INPUT_TYPE_COLOR) ?
Comment 6 Keishi Hattori 2012-03-30 04:30:44 PDT
Created attachment 134773 [details]
Patch
Comment 7 Kent Tamura 2012-03-30 06:00:25 PDT
Comment on attachment 134773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134773&action=review

> Source/WebKit/chromium/features.gypi:56
> -      'ENABLE_INPUT_TYPE_COLOR=0',
> +      'ENABLE_INPUT_TYPE_COLOR=1',

Maybe we need something for aura and Android?
Comment 8 WebKit Review Bot 2012-03-30 06:15:46 PDT
Comment on attachment 134773 [details]
Patch

Clearing flags on attachment: 134773

Committed r112658: <http://trac.webkit.org/changeset/112658>
Comment 9 WebKit Review Bot 2012-03-30 06:15:51 PDT
All reviewed patches have been landed.  Closing bug.