Bug 80971 - Remove obsolete constructors of CSSPrimitiveValue class.
Summary: Remove obsolete constructors of CSSPrimitiveValue class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 81077
  Show dependency tree / graph
 
Reported: 2012-03-13 00:32 PDT by Kwonjin Jeong
Modified: 2012-03-14 19:09 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.11 KB, patch)
2012-03-13 00:39 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2012-03-13 00:47 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwonjin Jeong 2012-03-13 00:32:30 PDT 
In CSSPrimitiveValueMappings.h file, there are many specialized template functions for CSSPrimitiveValue class. but the following constructors can't be reached.
* template<> inline CSSPrimitiveValue::CSSPrimitiveValue(int i)
* template<> inline CSSPrimitiveValue::CSSPrimitiveValue(unsigned i)

For the each constructors, there exists overloaded constructor that has the same parameter types as corresponding constructor. Therefore, the overloaded constructor is always called instead of template specialized one.

Moreover, they cause compile errors on the Intel compiler(icpc version 12.1.0) because icpc doesn't allow template function specialization with same parameter types as overloaded function.
Comment 1 Kwonjin Jeong 2012-03-13 00:39:16 PDT 
Created attachment 131566 [details]
Patch
Comment 2 Kwonjin Jeong 2012-03-13 00:47:31 PDT 
Created attachment 131567 [details]
Patch
Comment 3 Kwonjin Jeong 2012-03-13 22:06:45 PDT 
I create a new bug for Intel compiler support on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

You can build using Intel compiler referring to the bug.
Comment 4 Kwonjin Jeong 2012-03-14 18:06:45 PDT 
Would you give me some review about this patch?
Comment 5 WebKit Review Bot 2012-03-14 19:09:41 PDT 
Comment on attachment 131567 [details]
Patch

Clearing flags on attachment: 131567

Committed r110807: <http://trac.webkit.org/changeset/110807>
Comment 6 WebKit Review Bot 2012-03-14 19:09:46 PDT 
All reviewed patches have been landed.  Closing bug.