Bug 80931 - flexbox's computePreferredLogicalWidth needs to take multiline into account
Summary: flexbox's computePreferredLogicalWidth needs to take multiline into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-03-12 19:53 PDT by Tony Chang
Modified: 2012-03-13 11:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (72.99 KB, patch)
2012-03-12 19:55 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (72.88 KB, patch)
2012-03-13 09:44 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-03-12 19:53:53 PDT
flexbox's computePreferredLogicalWidth needs to take multiline into account
Comment 1 Tony Chang 2012-03-12 19:55:23 PDT
Created attachment 131498 [details]
Patch
Comment 2 Ojan Vafai 2012-03-12 20:07:14 PDT
Comment on attachment 131498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131498&action=review

cq- just to give you a chance to address the nits if you want to.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:192
> +                if (!isMultiline())

Nit: here and below i'd prefer to invert the if statement.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:861
> +        if (!isColumnFlow() && crossAxisLength().isAuto())

s/crossAxisLength/logicalHeight ? Not sure if that's better or worse.
Comment 3 Tony Chang 2012-03-13 09:44:55 PDT
Created attachment 131641 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-03-13 11:17:18 PDT
Comment on attachment 131641 [details]
Patch for landing

Clearing flags on attachment: 131641

Committed r110583: <http://trac.webkit.org/changeset/110583>
Comment 5 WebKit Review Bot 2012-03-13 11:17:23 PDT
All reviewed patches have been landed.  Closing bug.