Bug 80927 - [V8][Refactoring] Remove existingWrapper() from generated code
Summary: [V8][Refactoring] Remove existingWrapper() from generated code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 19:20 PDT by Kentaro Hara
Modified: 2012-03-12 21:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (19.68 KB, patch)
2012-03-12 19:24 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-03-12 19:20:48 PDT 
This is the final step for bug 80841. Currently wrap() calls existingWrapper(), and existingWrapper() just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.
Comment 1 Kentaro Hara 2012-03-12 19:24:06 PDT 
Created attachment 131493 [details]
Patch
Comment 2 Kentaro Hara 2012-03-12 19:25:37 PDT 
Comment on attachment 131493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131493&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:989
> +        my $domMapFunction = GetDomMapFunction($dataNode, $interfaceName);

Note: At this point, it is guaranteed that IsNodeSubType($dataNode) is false.
Comment 3 WebKit Review Bot 2012-03-12 21:03:44 PDT 
Comment on attachment 131493 [details]
Patch

Clearing flags on attachment: 131493

Committed r110535: <http://trac.webkit.org/changeset/110535>
Comment 4 WebKit Review Bot 2012-03-12 21:03:49 PDT 
All reviewed patches have been landed.  Closing bug.