Bug 80924 – [V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

getCachedWrapperSlow() is called by getCachedWrapper() only, and getCachedWrapperSlow() just calls getCachedWrapperInline(). Thus, we can expand getCachedWrapperInline() into getCachedWrapper(), which removes getCachedWrapperSlow().

[Kentaro Hara]

Created attachment 131487 [details]
Patch

[Adam Barth]

Comment on attachment 131487 [details]
Patch

This doesn't slow things down by inlining too much code?

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 131487 [details])
> This doesn't slow things down by inlining too much code?

I confirmed no perf regression in DOM core tests of DROMAEO. I do not think this change increases the inlined code. This change just moves getCachedWrapperInline(), which had been already inlined.

[Adam Barth]

Comment on attachment 131487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131487&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.h:-135
> -            return getCachedWrapperSlow(node);

This function used to be out-of-line, but I think that's fine.

[Kentaro Hara]

(In reply to comment #4)
> > Source/WebCore/bindings/v8/V8DOMWrapper.h:-135
> > -            return getCachedWrapperSlow(node);
> 
> This function used to be out-of-line, but I think that's fine.

Ah, I got it. Thanks for the clarification. Let me land it.

[WebKit Review Bot]

Comment on attachment 131487 [details]
Patch

Clearing flags on attachment: 131487

Committed r110536: <http://trac.webkit.org/changeset/110536>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.