Bug 80920 - [V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()
: [V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-03-12 18:16 PST by
Modified: 2012-03-12 19:27 PST (History)


Attachments
Patch (4.71 KB, patch)
2012-03-12 18:19 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff
patch for landing (5.78 KB, patch)
2012-03-12 18:35 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-12 18:16:28 PST
Now getExistingWrapper() is the same as getWrapper(). getExistingWrapperSlow() is the same as getWrapperSlow(). We can remove getExistingWrapper() and getExistingWrapperSlow().
------- Comment #1 From 2012-03-12 18:19:43 PST -------
Created an attachment (id=131481) [details]
Patch
------- Comment #2 From 2012-03-12 18:29:46 PST -------
(From update of attachment 131481 [details])
Can we call this getExistingWrapper since it doesn't create a wrapper?
------- Comment #3 From 2012-03-12 18:35:52 PST -------
Created an attachment (id=131485) [details]
patch for landing
------- Comment #4 From 2012-03-12 18:36:42 PST -------
(In reply to comment #2)
> (From update of attachment 131481 [details] [details])
> Can we call this getExistingWrapper since it doesn't create a wrapper?

I renamed it to getCachedWrapper(), following JSC's getCachedWrapper().
------- Comment #5 From 2012-03-12 18:39:10 PST -------
Committed r110525: <http://trac.webkit.org/changeset/110525>
------- Comment #6 From 2012-03-12 18:45:03 PST -------
> I renamed it to getCachedWrapper(), following JSC's getCachedWrapper().

Perfect.