RESOLVED FIXED 80920
[V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow() 
https://bugs.webkit.org/show_bug.cgi?id=80920
Summary [V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()
Kentaro Hara
Reported 2012-03-12 18:16:28 PDT
Now getExistingWrapper() is the same as getWrapper(). getExistingWrapperSlow() is the same as getWrapperSlow(). We can remove getExistingWrapper() and getExistingWrapperSlow().
Attachments
Patch (4.71 KB, patch)
2012-03-12 18:19 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (5.78 KB, patch)
2012-03-12 18:35 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-03-12 18:19:43 PDT
Created attachment 131481 [details] Patch
Adam Barth
Comment 2 2012-03-12 18:29:46 PDT
Comment on attachment 131481 [details] Patch Can we call this getExistingWrapper since it doesn't create a wrapper?
Kentaro Hara
Comment 3 2012-03-12 18:35:52 PDT
Created attachment 131485 [details] patch for landing
Kentaro Hara
Comment 4 2012-03-12 18:36:42 PDT
(In reply to comment #2) > (From update of attachment 131481 [details]) > Can we call this getExistingWrapper since it doesn't create a wrapper? I renamed it to getCachedWrapper(), following JSC's getCachedWrapper().
Kentaro Hara
Comment 5 2012-03-12 18:39:10 PDT
Committed r110525: <http://trac.webkit.org/changeset/110525>
Adam Barth
Comment 6 2012-03-12 18:45:03 PDT
> I renamed it to getCachedWrapper(), following JSC's getCachedWrapper(). Perfect.
Note You need to log in before you can comment on or make changes to this bug.