Bug 80920 – [V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()

Bug 80920 - [V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()


Summary:	[V8][Refactoring] Remove getExistingWrapper() and getExistingWrapperSlow()

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	WebCore JavaScript
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	Kentaro Hara

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-12 18:16 PDT by Kentaro Hara
Modified:	2012-03-12 19:27 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (4.71 KB, patch) 2012-03-12 18:19 PDT, Kentaro Hara	no flags	Details \| Formatted Diff \| Diff
patch for landing (5.78 KB, patch) 2012-03-12 18:35 PDT, Kentaro Hara	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kentaro Hara 2012-03-12 18:16:28 PDT

Now getExistingWrapper() is the same as getWrapper(). getExistingWrapperSlow() is the same as getWrapperSlow(). We can remove getExistingWrapper() and getExistingWrapperSlow().

Comment 1 Kentaro Hara 2012-03-12 18:19:43 PDT

Created attachment 131481 [details]
Patch

Comment 2 Adam Barth 2012-03-12 18:29:46 PDT

Comment on attachment 131481 [details]
Patch

Can we call this getExistingWrapper since it doesn't create a wrapper?

Comment 3 Kentaro Hara 2012-03-12 18:35:52 PDT

Created attachment 131485 [details]
patch for landing

Comment 4 Kentaro Hara 2012-03-12 18:36:42 PDT

(In reply to comment #2)
> (From update of attachment 131481 [details])
> Can we call this getExistingWrapper since it doesn't create a wrapper?

I renamed it to getCachedWrapper(), following JSC's getCachedWrapper().

Comment 5 Kentaro Hara 2012-03-12 18:39:10 PDT

Committed r110525: <http://trac.webkit.org/changeset/110525>

Comment 6 Adam Barth 2012-03-12 18:45:03 PDT

> I renamed it to getCachedWrapper(), following JSC's getCachedWrapper().

Perfect.