Bug 80917 - Refactor some code that is used to check whether a layer needs backing store
Summary: Refactor some code that is used to check whether a layer needs backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 18:04 PDT by Simon Fraser (smfr)
Modified: 2012-03-30 15:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.83 KB, patch)
2012-03-12 18:05 PDT, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-03-12 18:04:30 PDT 
Refactor some code that is used to check whether a layer needs backing store
Comment 1 Simon Fraser (smfr) 2012-03-12 18:05:55 PDT 
Created attachment 131478 [details]
Patch
Comment 2 Dean Jackson 2012-03-13 10:42:44 PDT 
Comment on attachment 131478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:-836
> -
> -    // If we have got this far and the renderer has no children, then we're ok.
> -    if (!renderObject->firstChild())
> -        return true;

It seems like this is no longer tested for an early return?
Comment 3 Simon Fraser (smfr) 2012-03-13 10:58:34 PDT 
(In reply to comment #2)
> (From update of attachment 131478 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:-836
> > -
> > -    // If we have got this far and the renderer has no children, then we're ok.
> > -    if (!renderObject->firstChild())
> > -        return true;

The checks for child renderers and child layers effectively do the same test.
> It seems like this is no longer tested for an early return?
Comment 4 Simon Fraser (smfr) 2012-03-30 15:32:35 PDT 
http://trac.webkit.org/changeset/110601