RESOLVED FIXED80917
Refactor some code that is used to check whether a layer needs backing store 
https://bugs.webkit.org/show_bug.cgi?id=80917
Summary Refactor some code that is used to check whether a layer needs backing store
Simon Fraser (smfr)
Reported 2012-03-12 18:04:30 PDT
Refactor some code that is used to check whether a layer needs backing store
Attachments
Patch (4.83 KB, patch)
2012-03-12 18:05 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-03-12 18:05:55 PDT
Created attachment 131478 [details] Patch
Dean Jackson
Comment 2 2012-03-13 10:42:44 PDT
Comment on attachment 131478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:-836 > - > - // If we have got this far and the renderer has no children, then we're ok. > - if (!renderObject->firstChild()) > - return true; It seems like this is no longer tested for an early return?
Simon Fraser (smfr)
Comment 3 2012-03-13 10:58:34 PDT
(In reply to comment #2) > (From update of attachment 131478 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:-836 > > - > > - // If we have got this far and the renderer has no children, then we're ok. > > - if (!renderObject->firstChild()) > > - return true; The checks for child renderers and child layers effectively do the same test. > It seems like this is no longer tested for an early return?
Simon Fraser (smfr)
Comment 4 2012-03-30 15:32:35 PDT
http://trac.webkit.org/changeset/110601
Note You need to log in before you can comment on or make changes to this bug.