Bug 80875 - GestureTapDown needs to pin in-progress flings
Summary: GestureTapDown needs to pin in-progress flings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 13:10 PDT by Robert Kroeger
Modified: 2012-03-16 17:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2012-03-12 13:18 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2012-03-16 15:50 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-03-12 13:10:35 PDT 
GestureTapDown should pin (i.e. stop) any in-progress animation.
Comment 1 Robert Kroeger 2012-03-12 13:18:58 PDT 
Created attachment 131392 [details]
Patch
Comment 2 Robert Kroeger 2012-03-12 15:04:55 PDT 
abarth@: please take a look?
Comment 3 Adam Barth 2012-03-15 15:41:58 PDT 
Comment on attachment 131392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131392&action=review

This looks fine.  I'm always torn for these patch in how hard I should push you for tests.  It seems like we don't have much test coverage for this code, which makes me worry that we'll break it in the future.

> Source/WebCore/page/EventHandler.cpp:2371
> +    FrameView* view = m_frame->view();
> +    if (view) {

Prefer early return.

> Source/WebCore/page/EventHandler.cpp:2375
> +           return false;

Bad indent.
Comment 4 Robert Kroeger 2012-03-15 16:17:41 PDT 
About tests: there should be a better way to test ScrollAnimatorNone-based behaviour. I plan on trying to write something as a prereq for https://bugs.webkit.org/show_bug.cgi?id=80596.
Comment 5 Robert Kroeger 2012-03-16 15:50:42 PDT 
Created attachment 132408 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-16 17:52:33 PDT 
Comment on attachment 132408 [details]
Patch

Clearing flags on attachment: 132408

Committed r111101: <http://trac.webkit.org/changeset/111101>
Comment 7 WebKit Review Bot 2012-03-16 17:52:38 PDT 
All reviewed patches have been landed.  Closing bug.