RESOLVED FIXED 80872
Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module. 
https://bugs.webkit.org/show_bug.cgi?id=80872
Summary Web Inspector: Changes to the list of scripts for front-end compilation shoul...
Vsevolod Vlasov
Reported 2012-03-12 12:55:47 PDT
Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
Attachments
Patch (22.93 KB, patch)
2012-03-12 13:03 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (22.96 KB, patch)
2012-03-12 13:20 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-03-12 13:03:42 PDT
Created attachment 131386 [details] Patch
WebKit Review Bot
Comment 2 2012-03-12 13:07:50 PDT
Attachment 131386 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/compile-front-end.py:42: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vsevolod Vlasov
Comment 3 2012-03-12 13:20:17 PDT
Created attachment 131393 [details] Patch
WebKit Review Bot
Comment 4 2012-03-12 13:24:23 PDT
Attachment 131393 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/compile-front-end.py:42: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 5 2012-03-13 01:02:53 PDT
Comment on attachment 131393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131393&action=review > Source/WebCore/inspector/compile-front-end.py:2 > +# Copyright (c) 2011 Google Inc. All rights reserved. 2012 > Source/WebCore/inspector/compile-front-end.py:47 > + "scripts": [ I would re-use gyp syntax here (target_name, sources, dependencies) so that we could eventually migrate to gyp modules.
Vsevolod Vlasov
Comment 6 2012-03-13 02:48:28 PDT
Committed r110550: <http://trac.webkit.org/changeset/110550>
Note You need to log in before you can comment on or make changes to this bug.