Bug 80872 - Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
Summary: Web Inspector: Changes to the list of scripts for front-end compilation shoul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 12:55 PDT by Vsevolod Vlasov
Modified: 2012-03-13 02:48 PDT (History)
11 users (show)

See Also:

Attachments
Patch (22.93 KB, patch)
2012-03-12 13:03 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (22.96 KB, patch)
2012-03-12 13:20 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-03-12 12:55:47 PDT 
Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
Comment 1 Vsevolod Vlasov 2012-03-12 13:03:42 PDT 
Created attachment 131386 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-12 13:07:50 PDT 
Attachment 131386 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/compile-front-end.py:42:  whitespace before '}'  [pep8/E202] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vsevolod Vlasov 2012-03-12 13:20:17 PDT 
Created attachment 131393 [details]
Patch
Comment 4 WebKit Review Bot 2012-03-12 13:24:23 PDT 
Attachment 131393 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/compile-front-end.py:42:  whitespace before '}'  [pep8/E202] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Pavel Feldman 2012-03-13 01:02:53 PDT 
Comment on attachment 131393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131393&action=review

> Source/WebCore/inspector/compile-front-end.py:2
> +# Copyright (c) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/compile-front-end.py:47
> +        "scripts": [

I would re-use gyp syntax here (target_name, sources, dependencies) so that we could eventually migrate to gyp modules.
Comment 6 Vsevolod Vlasov 2012-03-13 02:48:28 PDT 
Committed r110550: <http://trac.webkit.org/changeset/110550>