Bug 80868 - Make texImage2D error for wrong size ArrayBufferView more helpful
Summary: Make texImage2D error for wrong size ArrayBufferView more helpful
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 12:35 PDT by Gregg Tavares
Modified: 2012-03-12 14:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2012-03-12 12:38 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-03-12 12:35:47 PDT 
Make texImage2D error for wrong size ArrayBufferView more helpful
Comment 1 Gregg Tavares 2012-03-12 12:38:03 PDT 
Created attachment 131383 [details]
Patch
Comment 2 Gregg Tavares 2012-03-12 12:40:12 PDT 
I could just change the original message instead of adding the special check. I could also change the new message to something more verbose like "ArrayBufferView not big enough for request but would be if UNPACK_ALIGNMENT was set to 1"

thoughts?
Comment 3 Kenneth Russell 2012-03-12 13:01:44 PDT 
Comment on attachment 131383 [details]
Patch

Looks good. r=me
Comment 4 WebKit Review Bot 2012-03-12 14:15:38 PDT 
Comment on attachment 131383 [details]
Patch

Clearing flags on attachment: 131383

Committed r110477: <http://trac.webkit.org/changeset/110477>
Comment 5 WebKit Review Bot 2012-03-12 14:15:48 PDT 
All reviewed patches have been landed.  Closing bug.