Webcore module fails to build on windows 7 due to missing WTF header files. Due to the change in WTF and addition of WTFGenerated proj, the webcore is unable to find the WTF header files. Checked on Windows 7 build Revision 110420. Additional Information: Attached the build log for the same.
Created attachment 131385 [details] Patch
Comment on attachment 131385 [details] Patch Windows seems to be building fine at top-of-tree: http://build.webkit.org/waterfall?category=AppleWin Maybe the problem is related to your local configuration?
(In reply to comment #1) > Created an attachment (id=131385) [details] > Patch Should we fix the issue in this way Or as per https://lists.webkit.org/pipermail/webkit-dev/2012-March/019770.html, we should replace all instance of "Headerfile.h" with #include <wtf/Headerfile.h> ?
(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=131385) [details] [details] > > Patch > > Should we fix the issue in this way Or as per https://lists.webkit.org/pipermail/webkit-dev/2012-March/019770.html, we should replace all instance of "Headerfile.h" with #include <wtf/Headerfile.h> ? Fixing all the instance of "Headerfile.h" with #include <wtf/Headerfile.h> will be much more involved and prone to errors as than just adding extra include directories.
(In reply to comment #2) > (From update of attachment 131385 [details]) > Windows seems to be building fine at top-of-tree: > http://build.webkit.org/waterfall?category=AppleWin > > Maybe the problem is related to your local configuration? I'm not sure if it is a local configuration issue. Is there way to check it ?
#include <wtf/Headerfile.h> is the correct way.
(In reply to comment #5) > (In reply to comment #2) > > (From update of attachment 131385 [details] [details]) > > Windows seems to be building fine at top-of-tree: > > http://build.webkit.org/waterfall?category=AppleWin > > > > Maybe the problem is related to your local configuration? > > I'm not sure if it is a local configuration issue. Is there way to check it ? The revision you are using has the issue, as I also got same issue. But the latest revision seems to have solved it as Adam was suggesting.
(In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #2) > > > (From update of attachment 131385 [details] [details] [details]) > > > Windows seems to be building fine at top-of-tree: > > > http://build.webkit.org/waterfall?category=AppleWin > > > > > > Maybe the problem is related to your local configuration? > > > > I'm not sure if it is a local configuration issue. Is there way to check it ? > > The revision you are using has the issue, as I also got same issue. But the latest revision seems to have solved it as Adam was suggesting. Ok thanks
As adam barth said, the correct way to fix this is to to <wtf/HeaderFile.h>. Are you still seeing build issues? If not, please close this bug.