Bug 80862 - [Chromium] Temporary build-fix for the Android bot
Summary: [Chromium] Temporary build-fix for the Android bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 80861
  Show dependency tree / graph
 
Reported: 2012-03-12 11:33 PDT by Peter Beverloo
Modified: 2012-03-12 12:50 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2012-03-12 11:35 PDT, Peter Beverloo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-03-12 11:33:51 PDT 
[Chromium] Temporary build-fix for the Android bot
Comment 1 Peter Beverloo 2012-03-12 11:35:07 PDT 
Created attachment 131364 [details]
Patch
Comment 2 Peter Beverloo 2012-03-12 11:40:34 PDT 
Firstly: Yes, I'm aware that this is horrible.

A change in the Android envsetup.sh script at Chromium[1] has broken the WebKit Android builder, among another configuration. A Chromium-side fix is being created by bulach@ downstream but isn't ready to be upstreamed yet, and getting that into WebKit would take another day.

In the meantime there are two other compile errors which have gone unnoticed, unfortunately both on the Chromium side as well. To make sure things don't get significantly worse I'd like to have the bot compiling *something* asap, aiming to be completely green again by the end of this week.

This code will be removed very shortly after the Chromium-side fix is available, which shouldn't be more than a few days.

[1] http://src.chromium.org/viewvc/chrome?view=rev&revision=124565
Comment 3 Adam Barth 2012-03-12 11:41:59 PDT 
Comment on attachment 131364 [details]
Patch

Ok.
Comment 4 Peter Beverloo 2012-03-12 11:43:12 PDT 
Comment on attachment 131364 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-03-12 12:50:51 PDT 
Comment on attachment 131364 [details]
Patch

Clearing flags on attachment: 131364

Committed r110460: <http://trac.webkit.org/changeset/110460>
Comment 6 WebKit Review Bot 2012-03-12 12:50:55 PDT 
All reviewed patches have been landed.  Closing bug.