Bug 80858 - Connect up fling event delivery to gesture curve animation framework
Summary: Connect up fling event delivery to gesture curve animation framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on: 80607
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-12 10:47 PDT by Robert Kroeger
Modified: 2012-03-16 03:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2012-03-12 11:05 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2012-03-15 18:07 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-03-12 10:47:43 PDT 
To let https://bugs.webkit.org/show_bug.cgi?id=79827 and https://bugs.webkit.org/show_bug.cgi?id=80311 land separately, it was necessary to remove the final wiring connecting them. Add the necessary plumbing.
Comment 1 Robert Kroeger 2012-03-12 11:05:18 PDT 
Created attachment 131353 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-03-12 11:15:29 PDT 
Comment on attachment 131353 [details]
Patch

Attachment 131353 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11938985
Comment 3 WebKit Review Bot 2012-03-12 11:25:34 PDT 
Comment on attachment 131353 [details]
Patch

Attachment 131353 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11939950
Comment 4 Robert Kroeger 2012-03-12 12:17:04 PDT 
note: needs 80607 to build.
Comment 5 Adam Barth 2012-03-12 15:10:32 PDT 
Comment on attachment 131353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review

> Source/WebCore/platform/ScrollAnimatorNone.cpp:397
> +    if (!!m_gestureAnimation)

Do you need the !! here?
Comment 6 Robert Kroeger 2012-03-13 08:38:49 PDT 
Comment on attachment 131353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review

>> Source/WebCore/platform/ScrollAnimatorNone.cpp:397
>> +    if (!!m_gestureAnimation)
> 
> Do you need the !! here?

probably not. I'll update if so prior to committing.
Comment 7 Robert Kroeger 2012-03-15 18:07:44 PDT 
Created attachment 132167 [details]
Patch
Comment 8 WebKit Review Bot 2012-03-16 03:20:18 PDT 
Comment on attachment 132167 [details]
Patch

Clearing flags on attachment: 132167

Committed r110978: <http://trac.webkit.org/changeset/110978>
Comment 9 WebKit Review Bot 2012-03-16 03:20:23 PDT 
All reviewed patches have been landed.  Closing bug.