RESOLVED FIXED 80851
Update Chromium's test expectations wrt the approximation of Math.cos(Math.PI/2) 
https://bugs.webkit.org/show_bug.cgi?id=80851
Summary Update Chromium's test expectations wrt the approximation of Math.cos(Math.PI/2)
Yang Guo
Reported 2012-03-12 09:37:36 PDT
As of r10915, V8 has been updated to consistently use the FPU for Math.sin, Math.cos, Math.tan and Math.log across all Intel architectures. This changes the approximation of Math.cos(Math.PI/2), which ought to be 0, but yields 6.123031769111886e-17 (FPU) or 6.123233995736766e-17 (libc implementation on X86_64 and MSVC) alternatively. The difference can be explained by the extended 80-bit precision of the Intel FPU. This has led the test expectations to be wrong. The attached patch should correct them. Please review and commit this patch. Thanks!
Attachments
patch (15.00 KB, patch)
2012-03-12 09:38 PDT, Yang Guo 		no flags
DetailsFormatted DiffDiff
Updated patch. (17.72 KB, patch)
2012-03-15 11:20 PDT, Yang Guo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yang Guo
Comment 1 2012-03-12 09:38:01 PDT
Created attachment 131337 [details] patch
Yang Guo
Comment 2 2012-03-14 07:03:55 PDT
Do not land yet, as the changes have not been committed to Chromium yet.
Yang Guo
Comment 3 2012-03-15 11:20:53 PDT
Created attachment 132083 [details] Updated patch.
Yang Guo
Comment 4 2012-08-22 02:25:15 PDT
This patch is obsolete since the expectations got rebaselined.
Note You need to log in before you can comment on or make changes to this bug.