Bug 80820 - [BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
Summary: [BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatform...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-03-12 01:01 PDT by Leo Yang
Modified: 2012-03-12 19:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2012-03-12 01:28 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Patch v2 (1.83 KB, patch)
2012-03-12 01:38 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-12 01:01:48 PDT 
This is the BlackBerry specific change to platform/graphics/FontPlatformData.h. It's using the FontPlatformData from chromium.
Comment 1 Leo Yang 2012-03-12 01:28:25 PDT 
Created attachment 131291 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-12 01:31:33 PDT 
Attachment 131291 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/FontPlatformData.h:39:  "chromium/FontPlatformData.h" already included at Source/WebCore/platform/graphics/FontPlatformData.h:27  [build/include] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Leo Yang 2012-03-12 01:38:48 PDT 
Created attachment 131294 [details]
Patch v2

Satisfying the style bot.
Comment 4 Rob Buis 2012-03-12 08:53:51 PDT 
Comment on attachment 131294 [details]
Patch v2

LGTM.
Comment 5 Leo Yang 2012-03-12 18:36:13 PDT 
Comment on attachment 131294 [details]
Patch v2

Sending to the cq...
Comment 6 WebKit Review Bot 2012-03-12 19:17:47 PDT 
Comment on attachment 131294 [details]
Patch v2

Clearing flags on attachment: 131294

Committed r110528: <http://trac.webkit.org/changeset/110528>
Comment 7 WebKit Review Bot 2012-03-12 19:17:52 PDT 
All reviewed patches have been landed.  Closing bug.