Bug 80812 - [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
Summary: [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-11 22:28 PDT by Ming Xie
Modified: 2012-03-12 07:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch for the fix (2.39 KB, patch)
2012-03-11 22:44 PDT, Ming Xie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Xie 2012-03-11 22:28:18 PDT
For the BlackBerry port, "--cmakearg" from build-webkit options doesn't get passed to buildCMakeProjectOrExit()

Also, "PUBLIC_BUILD=0" should not be hard-coded in blackberryCMakeArguments()
Comment 1 Ming Xie 2012-03-11 22:44:03 PDT
Created attachment 131282 [details]
Patch for the fix
Comment 2 Rob Buis 2012-03-12 06:37:25 PDT
Comment on attachment 131282 [details]
Patch for the fix

LGTM.
Comment 3 WebKit Review Bot 2012-03-12 07:52:33 PDT
Comment on attachment 131282 [details]
Patch for the fix

Clearing flags on attachment: 131282

Committed r110427: <http://trac.webkit.org/changeset/110427>
Comment 4 WebKit Review Bot 2012-03-12 07:52:42 PDT
All reviewed patches have been landed.  Closing bug.