Bug 80809 - [GTK] r110296 included an extra $ in @$(AM_V_GEN)
Summary: [GTK] r110296 included an extra $ in @$(AM_V_GEN)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Major
Assignee: Nobody
URL:
Keywords:
: 80695 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-11 21:59 PDT by C Anthony
Modified: 2012-03-12 10:51 PDT (History)
4 users (show)

See Also:


Attachments
simple fix (447 bytes, patch)
2012-03-11 22:03 PDT, C Anthony
no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2012-03-12 09:53 PDT, C Anthony
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description C Anthony 2012-03-11 21:59:40 PDT
see: http://trac.webkit.org/changeset/110296/trunk/Tools/GNUmakefile.am

that should have been (note the additional `$` !!!):

@$(AM_V_GEN)$(PYTHON)

... NOT ...

@(AM_V_GEN)$(PYTHON)

... which causes a syntax error in /bin/sh (the @ tells make to run the following command silently).
Comment 1 C Anthony 2012-03-11 22:03:38 PDT
Created attachment 131280 [details]
simple fix

self-explanatory :-)
Comment 2 WebKit Review Bot 2012-03-11 22:05:02 PDT
Attachment 131280 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2012-03-12 09:24:24 PDT
Can you please provide a ChangeLog entry?
Comment 4 C Anthony 2012-03-12 09:53:09 PDT
Created attachment 131341 [details]
Patch
Comment 5 C Anthony 2012-03-12 09:54:51 PDT
ok, i used `Tools/Scripts/webkit-patch upload` this time :-)
Comment 6 Philippe Normand 2012-03-12 10:09:56 PDT
*** Bug 80695 has been marked as a duplicate of this bug. ***
Comment 7 WebKit Review Bot 2012-03-12 10:51:04 PDT
Comment on attachment 131341 [details]
Patch

Clearing flags on attachment: 131341

Committed r110446: <http://trac.webkit.org/changeset/110446>
Comment 8 WebKit Review Bot 2012-03-12 10:51:11 PDT
All reviewed patches have been landed.  Closing bug.