Bug 80798 - Web Inspector: WebKit1: update how the Web Inspector resources are loaded
Summary: Web Inspector: WebKit1: update how the Web Inspector resources are loaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-03-11 17:47 PDT by Timothy Hatcher
Modified: 2012-03-11 18:29 PDT (History)
4 users (show)

See Also:

Attachments
Proposed Change (9.20 KB, patch)
2012-03-11 17:53 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-03-11 17:47:35 PDT 
We need to update how WebKit1 loads the Web Inspector resources.

<rdar://problem/10359959>
Comment 1 Timothy Hatcher 2012-03-11 17:53:20 PDT 
Created attachment 131263 [details]
Proposed Change
Comment 2 Brian Weinstein 2012-03-11 17:58:28 PDT 
Comment on attachment 131263 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=131263&action=review

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:166
> +        ![[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"] pathForResource:@"Main" ofType:@"html"];

Should we save this result into a static so we don't have to compute this each time?
Comment 3 Timothy Hatcher 2012-03-11 18:01:29 PDT 
Nah, it isn't hot code.
Comment 4 WebKit Review Bot 2012-03-11 18:14:24 PDT 
Comment on attachment 131263 [details]
Proposed Change

Clearing flags on attachment: 131263

Committed r110403: <http://trac.webkit.org/changeset/110403>
Comment 5 WebKit Review Bot 2012-03-11 18:14:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Timothy Hatcher 2012-03-11 18:29:45 PDT 
Build fix landed in r110404.