Bug 80792 - [BlackBerry] Fix JPEG encoding support
Summary: [BlackBerry] Fix JPEG encoding support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-11 10:01 PDT by George Staikos
Modified: 2012-03-11 13:13 PDT (History)
3 users (show)

See Also:

Attachments
Part 1 - Build system (1.03 KB, patch)
2012-03-11 10:12 PDT, George Staikos 		no flags Details | Formatted Diff | Diff
Part 2 - Enabled commented-out code (1.46 KB, patch)
2012-03-11 10:13 PDT, George Staikos 		no flags Details | Formatted Diff | Diff
Single patch (1.18 KB, patch)
2012-03-11 11:12 PDT, George Staikos 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-03-11 10:01:35 PDT 
Inadvertently broken during some rebasing work.  This re-enables it.
Comment 1 George Staikos 2012-03-11 10:12:08 PDT 
Created attachment 131240 [details]
Part 1 - Build system
Comment 2 George Staikos 2012-03-11 10:13:02 PDT 
Created attachment 131241 [details]
Part 2 - Enabled commented-out code

Already r+ by Rob
Comment 3 Antonio Gomes 2012-03-11 10:37:25 PDT 
Comment on attachment 131240 [details]
Part 1 - Build system

View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review

> Source/WebCore/PlatformBlackBerry.cmake:84
>      platform/image-encoders/JPEGImageEncoder.cpp
> +    platform/image-encoders/skia/JPEGImageEncoder.cpp

so we build both now?
Comment 4 Antonio Gomes 2012-03-11 10:37:49 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review

oh forgor the changelog :(

> Source/WebCore/PlatformBlackBerry.cmake:84
>      platform/image-encoders/JPEGImageEncoder.cpp
> +    platform/image-encoders/skia/JPEGImageEncoder.cpp

so we build both now?
Comment 5 Antonio Gomes 2012-03-11 10:38:22 PDT 
Comment on attachment 131240 [details]
Part 1 - Build system

no changelog :(
Comment 6 George Staikos 2012-03-11 10:39:36 PDT 
(In reply to comment #4)
> View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review
> 
> oh forgor the changelog :(
> 
> > Source/WebCore/PlatformBlackBerry.cmake:84
> >      platform/image-encoders/JPEGImageEncoder.cpp
> > +    platform/image-encoders/skia/JPEGImageEncoder.cpp
> 
> so we build both now?

That's the confusing part.  They're different things.

(In reply to comment #5)
> (From update of attachment 131240 [details])
> no changelog :(

Woops!  I just uploaded the completely wrong set of patches it seems!
Comment 7 George Staikos 2012-03-11 11:12:23 PDT 
Created attachment 131249 [details]
Single patch

Turns out the other patch wasn't needed anyway.  Fixed, with changelog
Comment 8 WebKit Review Bot 2012-03-11 13:13:12 PDT 
Comment on attachment 131249 [details]
Single patch

Clearing flags on attachment: 131249

Committed r110399: <http://trac.webkit.org/changeset/110399>
Comment 9 WebKit Review Bot 2012-03-11 13:13:16 PDT 
All reviewed patches have been landed.  Closing bug.