Bug 80785 - Web Inspector: decouple LiveLocation from RawSourceCode.
Summary: Web Inspector: decouple LiveLocation from RawSourceCode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-11 04:42 PDT by Pavel Podivilov
Modified: 2012-03-12 01:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (19.88 KB, patch)
2012-03-11 04:43 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch (17.87 KB, patch)
2012-03-11 06:41 PDT, Pavel Podivilov 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-11 04:42:05 PDT 
Web Inspector: decouple LiveLocation from RawSourceCode.

Another step to get rid of RawSourceCode.
Comment 1 Pavel Podivilov 2012-03-11 04:43:31 PDT 
Created attachment 131216 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-11 06:25:03 PDT 
Comment on attachment 131216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131216&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:642
> +WebInspector.LiveLocation = function(model, rawLocation, updateDelegate)

This belongs to ScriptMapping.
Comment 3 Pavel Podivilov 2012-03-11 06:41:12 PDT 
Created attachment 131222 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-11 07:00:02 PDT 
Comment on attachment 131222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131222&action=review

> LayoutTests/inspector/debugger/callstack-placards-discarded.html:58
> +        var count = 0;

Object.keys(...).length

> LayoutTests/inspector/debugger/linkifier.html:71
>          var count = 0;

ditto.
Comment 5 Pavel Podivilov 2012-03-12 01:33:15 PDT 
Committed r110413: <http://trac.webkit.org/changeset/110413>