Bug 80784 - Web Inspector: [chromium] add provisional test for the downstream sanity test.
Summary: Web Inspector: [chromium] add provisional test for the downstream sanity test.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-11 01:05 PST by Pavel Feldman
Modified: 2013-04-05 13:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2012-03-11 01:08 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (6.75 KB, patch)
2012-03-12 10:05 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-03-11 01:05:41 PST 
Patch to follow.
Comment 1 Pavel Feldman 2012-03-11 01:08:58 PST 
Created attachment 131211 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-11 01:30:27 PST 
Comment on attachment 131211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131211&action=review

> Source/WebKit/chromium/src/js/Tests.js:590
> +            ++matchesCount;

Please use 2 booleans to check that you receive both log and error messages.
Comment 3 WebKit Review Bot 2012-03-11 06:16:05 PDT 
Comment on attachment 131211 [details]
Patch

Clearing flags on attachment: 131211

Committed r110391: <http://trac.webkit.org/changeset/110391>
Comment 4 WebKit Review Bot 2012-03-11 06:16:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2012-03-12 10:05:28 PDT 
Reopening to attach new patch.
Comment 6 Pavel Feldman 2012-03-12 10:05:32 PDT 
Created attachment 131342 [details]
Patch
Comment 7 Pavel Feldman 2012-03-12 10:06:43 PDT 
Comment on attachment 131342 [details]
Patch

(wrong bug)
Comment 8 Timothy Hatcher 2013-04-05 13:01:14 PDT 
Chromium and V8 have left the building. Won't fix.