Bug 80757 - REGRESSION(r110363): link error in chromium: unresolved external symbol webkit_support::CreateScopedTempDirectory(void) (Requested by ukai_home on #webkit).
Summary: REGRESSION(r110363): link error in chromium: unresolved external symbol webki...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 79413
  Show dependency treegraph
 
Reported: 2012-03-10 05:18 PST by WebKit Review Bot
Modified: 2012-03-10 07:52 PST (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r110363 (9.29 KB, patch)
2012-03-10 05:19 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-03-10 05:18:40 PST
http://trac.webkit.org/changeset/110363 broke the build:
link error in chromium: unresolved external symbol webkit_support::CreateScopedTempDirectory(void) (Requested by ukai_home on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-03-10 05:19:12 PST
Created attachment 131170 [details]
ROLLOUT of r110363

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Fumitoshi Ukai 2012-03-10 05:21:35 PST
http://build.chromium.org/p/chromium.webkit/builders/Win%20%28dbg%29/builds/5350/steps/compile/logs/stdio
Linking...
   Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
LevelDBTest.obj : error LNK2019: unresolved external symbol "class webkit_support::ScopedTempDirectory * __cdecl webkit_support::CreateScopedTempDirectory(void)" (?CreateScopedTempDirectory@webkit_support@@YAPAVScopedTempDirectory@1@XZ) referenced in function "private: virtual void __thiscall `anonymous namespace'::LevelDBDatabaseTest_CorruptionTest_Test::TestBody(void)" (?TestBody@LevelDBDatabaseTest_CorruptionTest_Test@?A0x04e6fed8@@EAEXXZ)
../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals

Error executing link.exe (tool returned code: 1120)
 

collober build doesn't fix.
http://build.chromium.org/p/chromium.webkit/builders/Win%20%28dbg%29/builds/5351
Linking...
   Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
LevelDBTest.obj : error LNK2019: unresolved external symbol "class webkit_support::ScopedTempDirectory * __cdecl webkit_support::CreateScopedTempDirectory(void)" (?CreateScopedTempDirectory@webkit_support@@YAPAVScopedTempDirectory@1@XZ) referenced in function "private: virtual void __thiscall `anonymous namespace'::LevelDBDatabaseTest_CorruptionTest_Test::TestBody(void)" (?TestBody@LevelDBDatabaseTest_CorruptionTest_Test@?A0x04e6fed8@@EAEXXZ)
../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals

Error executing link.exe (tool returned code: 1120)
Comment 3 WebKit Review Bot 2012-03-10 05:26:16 PST
Comment on attachment 131170 [details]
ROLLOUT of r110363

Clearing flags on attachment: 131170

Committed r110373: <http://trac.webkit.org/changeset/110373>
Comment 4 WebKit Review Bot 2012-03-10 05:26:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Joshua Bell 2012-03-10 07:38:28 PST
Ugh, sorry about this. :(

Built/ran locally for me on Windows and Linux, not sure what's up.
Comment 6 Joshua Bell 2012-03-10 07:52:21 PST
Ah... only affects the component build. The test file should have been excluded in WebKit.gyp:

 'sources!': [
                                # We should not include files depending on webkit_support.
                                # These tests depend on webkit_support and
                                # functions defined only in !WEBKIT_IMPLEMENTATION.
                                'tests/AssociatedURLLoaderTest.cpp',
                                'tests/FrameTestHelpers.cpp',
                                'tests/PopupMenuTest.cpp',
                                'tests/RenderTableCellTest.cpp',
                                'tests/WebFrameTest.cpp',
                                'tests/WebPageNewSerializerTest.cpp',
                                'tests/WebPageSerializerTest.cpp',
                                'tests/WebViewTest.cpp',
                            ],

Again, sorry about this. I won't try relanding until Monday.