Bug 80757 – REGRESSION(r110363): link error in chromium: unresolved external symbol webkit_support::CreateScopedTempDirectory(void) (Requested by ukai_home on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/110363 broke the build:
link error in chromium: unresolved external symbol webkit_support::CreateScopedTempDirectory(void) (Requested by ukai_home on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 131170 [details]
ROLLOUT of r110363

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Fumitoshi Ukai]

http://build.chromium.org/p/chromium.webkit/builders/Win%20%28dbg%29/builds/5350/steps/compile/logs/stdio
Linking...
   Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
LevelDBTest.obj : error LNK2019: unresolved external symbol "class webkit_support::ScopedTempDirectory * __cdecl webkit_support::CreateScopedTempDirectory(void)" (?CreateScopedTempDirectory@webkit_support@@YAPAVScopedTempDirectory@1@XZ) referenced in function "private: virtual void __thiscall `anonymous namespace'::LevelDBDatabaseTest_CorruptionTest_Test::TestBody(void)" (?TestBody@LevelDBDatabaseTest_CorruptionTest_Test@?A0x04e6fed8@@EAEXXZ)
../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals

Error executing link.exe (tool returned code: 1120)
 

collober build doesn't fix.
http://build.chromium.org/p/chromium.webkit/builders/Win%20%28dbg%29/builds/5351
Linking...
   Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
LevelDBTest.obj : error LNK2019: unresolved external symbol "class webkit_support::ScopedTempDirectory * __cdecl webkit_support::CreateScopedTempDirectory(void)" (?CreateScopedTempDirectory@webkit_support@@YAPAVScopedTempDirectory@1@XZ) referenced in function "private: virtual void __thiscall `anonymous namespace'::LevelDBDatabaseTest_CorruptionTest_Test::TestBody(void)" (?TestBody@LevelDBDatabaseTest_CorruptionTest_Test@?A0x04e6fed8@@EAEXXZ)
../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals

Error executing link.exe (tool returned code: 1120)

[WebKit Review Bot]

Comment on attachment 131170 [details]
ROLLOUT of r110363

Clearing flags on attachment: 131170

Committed r110373: <http://trac.webkit.org/changeset/110373>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Joshua Bell]

Ugh, sorry about this. :(

Built/ran locally for me on Windows and Linux, not sure what's up.

[Joshua Bell]

Ah... only affects the component build. The test file should have been excluded in WebKit.gyp:

 'sources!': [
                                # We should not include files depending on webkit_support.
                                # These tests depend on webkit_support and
                                # functions defined only in !WEBKIT_IMPLEMENTATION.
                                'tests/AssociatedURLLoaderTest.cpp',
                                'tests/FrameTestHelpers.cpp',
                                'tests/PopupMenuTest.cpp',
                                'tests/RenderTableCellTest.cpp',
                                'tests/WebFrameTest.cpp',
                                'tests/WebPageNewSerializerTest.cpp',
                                'tests/WebPageSerializerTest.cpp',
                                'tests/WebViewTest.cpp',
                            ],

Again, sorry about this. I won't try relanding until Monday.